Re: [patch] Streamlining collapsable status, inlined, etc. in InsetCollapsable

2007-08-16 Thread Martin Vermeer
On Thu, Aug 16, 2007 at 03:51:02PM +0200, Jean-Marc Lasgouttes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > > This was a great idea... result attached. I will commit this > > presently if I hear no objections. > > Good. It's committed. - Martin

Re: [patch] Streamlining collapsable status, inlined, etc. in InsetCollapsable

2007-08-16 Thread Jean-Marc Lasgouttes
Martin Vermeer <[EMAIL PROTECTED]> writes: > This was a great idea... result attached. I will commit this > presently if I hear no objections. Good. JMarc

Re: [patch] Streamlining collapsable status, inlined, etc. in InsetCollapsable

2007-08-16 Thread Martin Vermeer
On Thu, Aug 16, 2007 at 10:54:40AM +0200, Jean-Marc Lasgouttes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > > On Thu, Aug 16, 2007 at 09:23:40AM +0200, Jean-Marc Lasgouttes wrote: > >> Martin Vermeer <[EMAIL PROTECTED]> writes: > >> > >> > Hmmm, elsewhere in the code I see such constru

Re: [patch] Streamlining collapsable status, inlined, etc. in InsetCollapsable

2007-08-16 Thread Jean-Marc Lasgouttes
Martin Vermeer <[EMAIL PROTECTED]> writes: > On Thu, Aug 16, 2007 at 09:23:40AM +0200, Jean-Marc Lasgouttes wrote: >> Martin Vermeer <[EMAIL PROTECTED]> writes: >> >> > Hmmm, elsewhere in the code I see such constructs as >> > CS_LATEXNAME and TC_SOMETHING... we're not the first time >> > running

Re: [patch] Streamlining collapsable status, inlined, etc. in InsetCollapsable

2007-08-16 Thread Martin Vermeer
On Thu, Aug 16, 2007 at 09:23:40AM +0200, Jean-Marc Lasgouttes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > > Hmmm, elsewhere in the code I see such constructs as > > CS_LATEXNAME and TC_SOMETHING... we're not the first time > > running into this problem. > > Very good point :) So wha

Re: [patch] Streamlining collapsable status, inlined, etc. in InsetCollapsable

2007-08-16 Thread Jean-Marc Lasgouttes
Martin Vermeer <[EMAIL PROTECTED]> writes: > Hmmm, elsewhere in the code I see such constructs as > CS_LATEXNAME and TC_SOMETHING... we're not the first time > running into this problem. Very good point :) JMarc

Re: [patch] Streamlining collapsable status, inlined, etc. in InsetCollapsable

2007-08-15 Thread Martin Vermeer
On Thu, Aug 16, 2007 at 12:41:06AM +0200, Jean-Marc Lasgouttes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > New patch looks better. > > >> These things could _maybe_ be moved to insetlayout. > > > > Yes... but I'd rather not do that right now, as it would > > touch some files contain

Re: [patch] Streamlining collapsable status, inlined, etc. in InsetCollapsable

2007-08-15 Thread Jean-Marc Lasgouttes
Martin Vermeer <[EMAIL PROTECTED]> writes: New patch looks better. >> These things could _maybe_ be moved to insetlayout. > > Yes... but I'd rather not do that right now, as it would > touch some files containing another pending patch. OK >> I do not like these InlinedD/InlinedG. Isn't it pos

Re: [patch] Streamlining collapsable status, inlined, etc. in InsetCollapsable

2007-08-15 Thread Martin Vermeer
On Wed, Aug 15, 2007 at 04:05:16PM +0200, Jean-Marc Lasgouttes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > > Attached is a first attempt to streamline the handling of the > > various presentation modes of collapsable insets. > > I think this is something that is very worth doing and t

Re: [patch] Streamlining collapsable status, inlined, etc. in InsetCollapsable

2007-08-15 Thread Jean-Marc Lasgouttes
Martin Vermeer <[EMAIL PROTECTED]> writes: > Attached is a first attempt to streamline the handling of the > various presentation modes of collapsable insets. I think this is something that is very worth doing and the structure of the patch is sound. Some comments on the code follow. JMarc >

[patch] Streamlining collapsable status, inlined, etc. in InsetCollapsable

2007-08-13 Thread Martin Vermeer
Attached is a first attempt to streamline the handling of the various presentation modes of collapsable insets. To do still: 1) really remove the Inlined value from the CollapseStatus enum 2) same from the ERT dialog 3) move the drawing of "Conglomerate-style" inset presentation from CharStyle to