Re: [patch] Ninth rowlist patch.

2003-04-01 Thread Lars Gullik Bjønnes
Alfredo Braunstein <[EMAIL PROTECTED]> writes: | So I've solved it in a somewhat ugly way by adding a flag that tells if | prevrit is pointing to a valid position or else we will need to take | rows().begin(). Maybe you can rewrite it in a less ugly way... I am just applying this patch, but I ha

Re: [patch] Ninth rowlist patch.

2003-04-01 Thread Alfredo Braunstein
Lars Gullik Bjønnes wrote: > I'll apply it before anyne else finds more errors. :-) Oops, I had: a b and make a selection that spans the two rows (for instance the last a and first b) and cut: crash The problem is that my previous solution for prevrit is not good enough if for instance

Re: [patch] Ninth rowlist patch.

2003-03-31 Thread Lars Gullik Bjønnes
Alfredo Braunstein <[EMAIL PROTECTED]> writes: | True, it undo works with 1) solved. [...] | this modified redoParagraphs solves 1) (and the undo) and 2) for me (the | modified regions are above ^, sorry for not providing a patch | against your patch, I'm too lazy to cvs up and reapp

Re: [patch] Ninth rowlist patch.

2003-03-31 Thread Alfredo Braunstein
Lars Gullik Bjønnes wrote: > Alfredo Braunstein <[EMAIL PROTECTED]> writes: > > | Lars Gullik Bjønnes wrote: > | > | > This patch basically rewrites redoParagraphs to use the > | > RowList::iterators instead of Row*. > | > > | > This is a very important function and quite complex too, so strang

Re: [patch] Ninth rowlist patch.

2003-03-31 Thread Lars Gullik Bjønnes
Alfredo Braunstein <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | | > This patch basically rewrites redoParagraphs to use the | > RowList::iterators instead of Row*. | > | > This is a very important function and quite complex too, so strange | > things might arise here. | | 1) It cr

Re: [patch] Ninth rowlist patch.

2003-03-31 Thread Alfredo Braunstein
Lars Gullik Bjønnes wrote: > This patch basically rewrites redoParagraphs to use the > RowList::iterators instead of Row*. > > This is a very important function and quite complex too, so strange > things might arise here. 1) It crashes on cut: aaa| select the last 'a' and cut: crash. The b

[patch] Ninth rowlist patch.

2003-03-31 Thread Lars Gullik Bjønnes
This patch basically rewrites redoParagraphs to use the RowList::iterators instead of Row*. This is a very important function and quite complex too, so strange things might arise here. Would be nice if people could test this a bit. Index: po/POTFILES.in =