Lars Gullik Bjønnes wrote:

> This patch basically rewrites redoParagraphs to use the
> RowList::iterators instead of Row*.
> 
> This is a very important function and quite complex too, so strange
> things might arise here.

1) It crashes on cut:

aaaaaaa|

select the last 'a' and cut: crash. The backtrace shows that the problem is
that there is no check that tmprit != begin() in:

+        RowList::iterator prevrit = boost::prior(tmprit);

and below we have:

+        if (prevrit != rows().begin()) {
+                setHeightOfRow(prevrit);


2) 

aaaaaaa
bbbbbbb|

select the last b and cut: the rows become inverted.

I'm digging further on this other one.

Alfredo


Reply via email to