Re: [patch] InsetGraphics Safety

2008-03-25 Thread Andre Poenitz
On Tue, Mar 25, 2008 at 12:15:12PM -0400, rgheck wrote: > Andre Poenitz wrote: >> On Tue, Mar 25, 2008 at 01:38:06AM -0400, rgheck wrote: >> >>> This patch prevents InsetGraphics from being created without a Buffer. >>> Comments? >>> >> >> General direction is ok. >> >> > It seems like

Re: [patch] InsetGraphics Safety

2008-03-25 Thread rgheck
Andre Poenitz wrote: On Tue, Mar 25, 2008 at 01:38:06AM -0400, rgheck wrote: This patch prevents InsetGraphics from being created without a Buffer. Comments? General direction is ok. It seems like doing this across the board would solve a lot of these buffer pointer crashes. And i

Re: [patch] InsetGraphics Safety

2008-03-25 Thread Andre Poenitz
On Tue, Mar 25, 2008 at 01:38:06AM -0400, rgheck wrote: > > This patch prevents InsetGraphics from being created without a Buffer. > Comments? General direction is ok. Note that a private (class) static function could as well be a freestanding (anonymous/static) function in the cpp: > ///

[patch] InsetGraphics Safety

2008-03-24 Thread rgheck
This patch prevents InsetGraphics from being created without a Buffer. Comments? rh Index: src/CutAndPaste.cpp === --- src/CutAndPaste.cpp (revision 23930) +++ src/CutAndPaste.cpp (working copy) @@ -859,7 +859,7 @@ return;