On Tue, Mar 25, 2008 at 01:38:06AM -0400, rgheck wrote:
>
> This patch prevents InsetGraphics from being created without a Buffer. 
> Comments?

General direction is ok.

Note that a private (class) static function could as well be a
freestanding (anonymous/static) function in the cpp:

>       /// Read the inset native format
> -     void readInsetGraphics(Lexer & lex, std::string const & bufpath);
> +     static void readInsetGraphics(Lexer & lex, std::string const & bufpath,
> +                     InsetGraphicsParams & params);
>  
>       /// Get the status message, depends on the image loading status.
>       std::string const statusMessage() const;


Andre'

Reply via email to