Re: [patch] IU...

2004-02-16 Thread Andre Poenitz
On Mon, Feb 16, 2004 at 11:03:39AM +0100, Andre' Poenitz wrote: > This brings tabulars back from zombie state to 'staggering zombie' > state. Left/Right should work, even (partially) with selection, up/down > crashes (most of the time...) I forgot to add: This also removes almost all of the remain

[patch] IU...

2004-02-16 Thread Andre Poenitz
This brings tabulars back from zombie state to 'staggering zombie' state. Left/Right should work, even (partially) with selection, up/down crashes (most of the time...) This also changes the signature of the InsetFoo::priv_dispatch functions. By assuming a 'default return' of 'DispatchResult(tru

Re: [patch] IU: types

2004-01-13 Thread Andre Poenitz
On Tue, Jan 13, 2004 at 12:26:08PM +, Angus Leeming wrote: > Andre Poenitz wrote: > > > > > This unifies a few types used in LCursor and the math cursor. > > > > Note that this unifies on the 'wrong side': paroffset_type should be > > unsigned in the long run but there seems to be a place or

Re: [patch] IU: types

2004-01-13 Thread Angus Leeming
Andre Poenitz wrote: > > This unifies a few types used in LCursor and the math cursor. > > Note that this unifies on the 'wrong side': paroffset_type should be > unsigned in the long run but there seems to be a place or two where > the core code relies on signedness (a downward counting loop mos

[patch] IU: types

2004-01-13 Thread Andre Poenitz
This unifies a few types used in LCursor and the math cursor. Note that this unifies on the 'wrong side': paroffset_type should be unsigned in the long run but there seems to be a place or two where the core code relies on signedness (a downward counting loop most likely). It works as-is and cou

[patch] IU of clone()

2003-06-16 Thread Andre Poenitz
Straight forward stuff, it just touches all of mathed/* and insets/*. I had to use a few (three?) static casts that will go away again after full IU. Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jefferson or B.

Re: [patch] IU, draw(), some of the 'controversial' stuff.

2003-06-03 Thread John Levon
On Mon, Jun 02, 2003 at 12:19:18PM +0200, Andre Poenitz wrote: > As I said, we call metrics() immediately before draw() (and stores it in > the 'dim_' 'cache) so there should be no need to do it in draw() again. > > If there was, something else is broken... seems OK to me regards john

[patch] IU, draw(), some of the 'controversial' stuff.

2003-06-02 Thread Andre Poenitz
As I said, we call metrics() immediately before draw() (and stores it in the 'dim_' 'cache) so there should be no need to do it in draw() again. If there was, something else is broken... Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they d

Re: [patch] IU: first phase

2003-06-02 Thread Andre Poenitz
On Sun, Jun 01, 2003 at 01:14:35AM +0100, John Levon wrote: > On Fri, May 30, 2003 at 11:07:31AM +0200, Andre Poenitz wrote: > > > With this, we have IU for drawing related stuff > > (i.e. both phases) > > You seem to mix up simple "no change" stuff with semantic changes such > as : > > @@ -342,

Re: [patch] IU: first phase

2003-06-01 Thread John Levon
On Fri, May 30, 2003 at 11:07:31AM +0200, Andre Poenitz wrote: > With this, we have IU for drawing related stuff > (i.e. both phases) You seem to mix up simple "no change" stuff with semantic changes such as : @@ -342,15 +342,12 @@ void InsetGraphics::draw(PainterInfo & p cache_->view =

Re: [patch] IU: draw()

2003-05-31 Thread John Levon
On Fri, May 30, 2003 at 04:42:29PM +0200, Andre Poenitz wrote: > Do you think you (i.e. you and Lars) will figure that out by that time or > should I try it myself. I reckon we'll be OK. The thing I'm worried about now is the unknown source of the inset_[const_]iterator breakage (insert->citatio

Re: [patch] IU: draw()

2003-05-31 Thread Andre Poenitz
On Fri, May 30, 2003 at 03:31:46PM +0100, John Levon wrote: > > By removing the line buffer_ = lp.buffer_ ? > > Look up I already posted the patch :) Fine. I have to leave now and I'll be off until Monday. Do you think you (i.e. you and Lars) will figure that out by that time or should I try i

Re: [patch] IU: draw()

2003-05-31 Thread John Levon
On Fri, May 30, 2003 at 04:09:58PM +0200, Andre Poenitz wrote: > By removing the line buffer_ = lp.buffer_ ? Look up I already posted the patch :) It just needs Lars to fill in some bits I'm not comforatable with in cut and paste regards john

Re: [patch] IU: draw()

2003-05-31 Thread Andre Poenitz
On Fri, May 30, 2003 at 04:05:55PM +0200, Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | On Fri, May 30, 2003 at 01:26:14PM +0100, John Levon wrote: > | > Never mind, it seemed OK anyway. Though I agree with Lars we should > | > lockdown for a bit and concentrate on u

Re: [patch] IU: draw()

2003-05-31 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Fri, May 30, 2003 at 01:26:14PM +0100, John Levon wrote: | > Never mind, it seemed OK anyway. Though I agree with Lars we should | > lockdown for a bit and concentrate on undo and the broken inset | > iterators | | Hm. All crashes I currently get are

Re: [patch] IU: draw()

2003-05-30 Thread Andre Poenitz
On Fri, May 30, 2003 at 01:26:14PM +0100, John Levon wrote: > Never mind, it seemed OK anyway. Though I agree with Lars we should > lockdown for a bit and concentrate on undo and the broken inset > iterators Hm. All crashes I currently get are asserts in boost::optional. They go magically away if

Re: [patch] IU: draw()

2003-05-30 Thread John Levon
On Fri, May 30, 2003 at 08:54:20AM +0200, Andre Poenitz wrote: > I really checked all mail before I commited, you just missed it by a few > seconds. Never mind, it seemed OK anyway. Though I agree with Lars we should lockdown for a bit and concentrate on undo and the broken inset iterators regar

Re: [patch] IU: first phase

2003-05-30 Thread Andre Poenitz
On Fri, May 30, 2003 at 11:07:31AM +0200, Andre' Poenitz wrote: > To really benefit from the two-stage drawing, "... on top of cleaner code ..." This removes some _really_ ugly glue between mathed and the outside work (most notably the different metrics() hacks and the cached font_ member) > t

[patch] IU: first phase

2003-05-30 Thread Andre Poenitz
With this, we have IU for drawing related stuff (i.e. both phases) To really benefit from the two-stage drawing, the row painter would need some work. [After that I'd guess we could even have a shot at removal of all 'update' stuff (at least to get a feeling on what would break and what that upd

Re: [patch] IU: draw()

2003-05-30 Thread Andre Poenitz
On Fri, May 30, 2003 at 08:47:26AM +0200, Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | This is "InsetUnificiation" for draw() > > I'd like this patch to go in, _BUT_ I'd like more to stabilize and > remove the breakage we have a bit first. Sorry, too late. I re

Re: [patch] IU: draw()

2003-05-30 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | This is "InsetUnificiation" for draw() I'd like this patch to go in, _BUT_ I'd like more to stabilize and remove the breakage we have a bit first. John has been helping me with this, so the greatest help I (we) can get now is to test and help finaliz

[patch] IU: draw()

2003-05-30 Thread Andre Poenitz
This is "InsetUnificiation" for draw() [And incidentally the second phase of the two-phase drawing, and 80 lines of removed code] There should be no user visible change, but I am not 100% sure because of the 'float x' -> 'int x' change. Known drawback: For Insets that do not properly impl