On Sun, Jun 01, 2003 at 01:14:35AM +0100, John Levon wrote: > On Fri, May 30, 2003 at 11:07:31AM +0200, Andre Poenitz wrote: > > > With this, we have IU for drawing related stuff > > (i.e. both phases) > > You seem to mix up simple "no change" stuff with semantic changes such > as : > > @@ -342,15 +342,12 @@ void InsetGraphics::draw(PainterInfo & p > cache_->view = bv->owner()->view(); > int oasc = cache_->old_ascent; > > - Dimension dim; > - dimension(bv, pi.base.font, dim); > - > // we may have changed while someone other was drawing us so better > // to not draw anything as we surely call to redraw ourself soon. > // This is not a nice thing to do and should be fixed properly somehow. > // But I still don't know the best way to go. So let's do this like this > // for now (Jug 20020311) > - if (dim.asc != oasc) > + if (dim_.asc != oasc) > return;
Ok, I see what you mean. The point is that 'metrics' (which sets dim_) is called immediately before 'draw' so this should just remove double metrics computations. But you are right, I'll drop that change from the patch and put it into a separate patch just to be on the safe side. > IOW, can we have first a patch that simply makes s/dimension/metrics/, > then one that does s/BufferView *, LyXFont const &/MetricsInfo &/ then > the semantic changes bit by bit ? I'll try to remove some 'non-obvious' bits. Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jefferson or B. Franklin or both...)
