Re: [patch] #2179 LaTeX and chktex error handling problem

2009-08-05 Thread John McCabe-Dansted
On Wed, Aug 5, 2009 at 4:46 PM, Jürgen Spitzmüller wrote: > Well, at least I have it installed, and I played a bit with it in the past. To > me, it looks interesting and useful, especially since there is a German GC > available. So I am a potential user. I have found another regression in 1.6; now

Re: [patch] #2179 LaTeX and chktex error handling problem

2009-08-05 Thread Jürgen Spitzmüller
John McCabe-Dansted wrote: > The patch relies on the fact that the the ErrorList dialog is only > updated before it is shown. Thus we can safely prevent updateContents > from regenerating the list of errors unless showEvent has been called. > Regenerating the list of Errors is problematic because A

Re: [patch] #2179 LaTeX and chktex error handling problem

2009-08-04 Thread John McCabe-Dansted
On Tue, Aug 4, 2009 at 10:30 PM, Jürgen Spitzmüller wrote: > John McCabe-Dansted wrote: >> Attached is a patch that does (2). > > I admit that I do not really understand what you are doing with the patch. The patch relies on the fact that the the ErrorList dialog is only updated before it is shown

Re: [patch] #2179 LaTeX and chktex error handling problem

2009-08-04 Thread Jürgen Spitzmüller
John McCabe-Dansted wrote: > Attached is a patch that does (2). I admit that I do not really understand what you are doing with the patch. Jürgen

Re: [patch] #2179 LaTeX and chktex error handling problem

2009-07-29 Thread John McCabe-Dansted
OK, I noticed a problem in the last patch. It would cause the error in the ErrorListDialog to become unhighlighted when clicking on the main window. The root cause of the problem appears to be that GuiDialog::updateView calls updateContents, which causes ErrorListDialog to reread all the error eac

[patch] #2179 LaTeX and chktex error handling problem

2009-07-29 Thread John McCabe-Dansted
How does this patch look? I thought it would be cleaner if I could avoid needing to add the variable "bool need_to_set_row", however I cannot see how this could be done. If I put setCurrentRow(0) in GuiErrorList::showEvent it doesn't do anything, and calling setCurrentRow(0) on every update was the