On Tue, Aug 4, 2009 at 10:30 PM, Jürgen Spitzmüller<sp...@lyx.org> wrote:
> John McCabe-Dansted wrote:
>> Attached is a patch that does (2).
>
> I admit that I do not really understand what you are doing with the patch.

The patch relies on the fact that the the ErrorList dialog is only
updated before it is shown. Thus we can safely prevent updateContents
from regenerating the list of errors unless showEvent has been called.
Regenerating the list of Errors is problematic because AFAICT:
  1) This leads to no errors being selected.
  2) Selecting the first error via setCurrentRow(0) on updateView is
problematic because this forces the first error to be highlighted
whenever the ErrorList window isn't focused. (And
GuiDialog::updateView calls updateContents)

I note that preventing the list from being unnecessarily regenerated
has another benefit: the list doesn't flicker on losing focus.

Does this help?

The reason I find this bug so annoying is because I use LyX-GC, which
relies heavily on this dialog. I am not sure how many other people use
it.  Doing a quick web search, apart from wikipedia the only people of
who mention LyX-GC are scammers who need fake webpage titles. It is
quite possible that there only a couple of users.

Reply via email to