Re: [PrePatch] New Graphics dialog for Xforms; Help needed!

2002-08-18 Thread John Levon
On Mon, Aug 19, 2002 at 01:18:30AM +0900, Rob Lahaye wrote: > graphics > dialog needs an update, that removes the redundant buttons and intput > fields. > I would like to leave that up to you. Sure. > Indeed I'm removing stuff and reinterpreting the left-over stuff. > Backwards compatibility m

Re: [PrePatch] New Graphics dialog for Xforms; Help needed!

2002-08-18 Thread Dekel Tsur
On Sun, Aug 18, 2002 at 04:50:51PM +0100, John Levon wrote: > > That's what I mean - why ? I admit I am too lazy to look at the patch > but I thought Rob was just removing stuff. Even if he was only removing stuff, it should be considered as a format change. But we already have the change size_

Re: [PrePatch] New Graphics dialog for Xforms; Help needed!

2002-08-18 Thread Rob Lahaye
John Levon wrote: > On Sun, Aug 18, 2002 at 06:41:03PM +0300, Dekel Tsur wrote: > > >>On Sun, Aug 18, 2002 at 04:03:55PM +0100, John Levon wrote: >> >>>On Sun, Aug 18, 2002 at 04:52:47PM +0300, Dekel Tsur wrote: >>> >>> Shouldn't the format be > 1 ? However, I don't see why we should sto

Re: [PrePatch] New Graphics dialog for Xforms; Help needed!

2002-08-18 Thread John Levon
On Sun, Aug 18, 2002 at 06:41:03PM +0300, Dekel Tsur wrote: > On Sun, Aug 18, 2002 at 04:03:55PM +0100, John Levon wrote: > > On Sun, Aug 18, 2002 at 04:52:47PM +0300, Dekel Tsur wrote: > > > > > Shouldn't the format be > 1 ? > > > However, I don't see why we should store the format # in the ins

Re: [PrePatch] New Graphics dialog for Xforms; Help needed!

2002-08-18 Thread Dekel Tsur
On Sun, Aug 18, 2002 at 04:03:55PM +0100, John Levon wrote: > On Sun, Aug 18, 2002 at 04:52:47PM +0300, Dekel Tsur wrote: > > > Shouldn't the format be > 1 ? > > However, I don't see why we should store the format # in the inset. > > I don't see why the output format needs changing. Instead we j

Re: [PrePatch] New Graphics dialog for Xforms; Help needed!

2002-08-18 Thread John Levon
On Sun, Aug 18, 2002 at 04:52:47PM +0300, Dekel Tsur wrote: > Shouldn't the format be > 1 ? > However, I don't see why we should store the format # in the inset. I don't see why the output format needs changing. Instead we just deprecate the bits we don't use any more. regards john -- "Someon

Re: [PrePatch] New Graphics dialog for Xforms; Help needed!

2002-08-18 Thread Dekel Tsur
On Sat, Aug 17, 2002 at 02:23:09AM +0900, Rob Lahaye wrote: > The following is an excerpt from the LyX output file that has two graphics insets, >the > first simply with the graphics default values, the second with everthing non-default. > > --

Re: [PrePatch] New Graphics dialog for Xforms; Help needed!

2002-08-16 Thread Angus Leeming
On Friday 16 August 2002 6:23 pm, Rob Lahaye wrote: > Angus Leeming wrote: > > That should get you started. > > Yep, thanks for your help. Pleasure > Is the patch okay for applying? If so, I send it again tomorrow with a > decent ChangLog. Next, I would like to do a clean up of all the stuff > t

Re: [PrePatch] New Graphics dialog for Xforms; Help needed!

2002-08-16 Thread Rob Lahaye
Angus Leeming wrote: > > That should get you started. Yep, thanks for your help. Attached is the new Xforms Graphics dialog. The dialog itself is slightly improved from last prepatch and I've done the implementation of the new input fields. Many buttons have disappeared in the dialog, so a lot

Re: [PrePatch] New Graphics dialog for Xforms; Help needed!

2002-08-16 Thread Angus Leeming
On Friday 16 August 2002 4:35 pm, John Levon wrote: > > > Then do something like "igp.rotate == rotvalue != 0.0;" > > > to enable it as necessary > > support/lyxlib.h: if (float_equal(var, number, 0.0001)) > again that's not needed in this case is it ?? More barminess. rotvalue is a float. Yo

Re: [PrePatch] New Graphics dialog for Xforms; Help needed!

2002-08-16 Thread John Levon
On Fri, Aug 16, 2002 at 04:18:48PM +0100, Angus Leeming wrote: > support/lyxlib.h: if (float_equal(var, number, 0.0001)) again that's not needed in this case is it ?? regards john -- "Someone turn off the good idea tap; we're drowning here!" - Rusty Russell

Re: [PrePatch] New Graphics dialog for Xforms; Help needed!

2002-08-16 Thread Angus Leeming
On Friday 16 August 2002 4:35 pm, John Levon wrote: > in apply() read the input box and convert it to a double using strToDbl > as you do already. Then do something like "igp.rotate == rotvalue != 0.0;" > to enable it as necessary support/lyxlib.h: if (float_equal(var, number, 0.0001)) Angus

Re: [PrePatch] New Graphics dialog for Xforms; Help needed!

2002-08-16 Thread John Levon
On Fri, Aug 16, 2002 at 07:59:43PM +0900, Rob Lahaye wrote: > So the layout is there. I needed to introduce one new param, > called "int lyxdisplay" in insetgrahpicsParams.h, to handle > the new LyX display choice selector. No, you don't need to do this. Convert the setting of the combo box into

Re: [PrePatch] New Graphics dialog for Xforms; Help needed!

2002-08-16 Thread Angus Leeming
On Friday 16 August 2002 11:59 am, Rob Lahaye wrote: > Hi, > > I have attached a patch for the new graphics dialog. > Main focus of the patch is the layout. I desperately need > help to implement the (new) items, since I have no clue how > and where to do that properly, without breaking too much.

[PrePatch] New Graphics dialog for Xforms; Help needed!

2002-08-16 Thread Rob Lahaye
Hi, I have attached a patch for the new graphics dialog. Main focus of the patch is the layout. I desperately need help to implement the (new) items, since I have no clue how and where to do that properly, without breaking too much. So the layout is there. I needed to introduce one new param, c