Re: [Patch-Qt4] QWorkArea cleanup

2006-03-12 Thread Georg Baum
Am Sonntag, 12. März 2006 19:44 schrieb Abdelrazak Younes: > This is Trolltech fault, from the documentation: > > Q_OS_X11 > Defined for the X Window System. > Q_OS_MAC9 > Defined for Mac OS 9. > Q_OS_MACX > Defined for Mac OS X. > Q_OS_WIN32 > Defined on Win32 (Windows 98/ME and Windows NT/2000/X

Re: [Patch-Qt4] QWorkArea cleanup

2006-03-12 Thread Abdelrazak Younes
Juergen Spitzmueller a écrit : Abdelrazak Younes wrote: Could someone please commit this? Done. However: +/// +// Specific stuff +#ifdef Q_OS_X11 #include #endif This has to be Q_WS_X11, else I get a compilation error here OK

Re: [Patch-Qt4] QWorkArea cleanup

2006-03-12 Thread Juergen Spitzmueller
Abdelrazak Younes wrote: > Should I provide a corrected patch or have you done something Juergen? No, I've nothing. Jürgen

Re: [Patch-Qt4] QWorkArea cleanup

2006-03-12 Thread Abdelrazak Younes
Georg Baum a écrit : Am Sonntag, 12. März 2006 18:30 schrieb Juergen Spitzmueller: +/// +// Specific stuff +#ifdef Q_OS_X11 #include #endif This has to be Q_WS_X11, else I get a compilation error here There still seems to be a gen

Re: [Patch-Qt4] QWorkArea cleanup

2006-03-12 Thread Georg Baum
Am Sonntag, 12. März 2006 18:30 schrieb Juergen Spitzmueller: > > +/// > > +// Specific stuff > > +#ifdef Q_OS_X11 > >  #include > >  #endif > > This has to be Q_WS_X11, else I get a compilation error here There still seems to be a gene

Re: [Patch-Qt4] QWorkArea cleanup

2006-03-12 Thread Juergen Spitzmueller
Abdelrazak Younes wrote: > Could someone please commit this? Done. However: > +/// > +// Specific stuff > +#ifdef Q_OS_X11 >  #include >  #endif This has to be Q_WS_X11, else I get a compilation error here > +/

Re: [Patch-Qt4] QWorkArea cleanup

2006-03-11 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | PS: Lars, I sent you a private email about this svn account, I don't | know if you received it. In progress. -- Lgb

Re: [Patch-Qt4] QWorkArea cleanup

2006-03-11 Thread Abdelrazak Younes
Abdelrazak Younes a écrit : Hello, Could someone please commit this? I would like applied before I the following one which conatains compilation fixes for MacOSX. In English this means: I would like it applied before the following one which contains compilation fixes for MacOSX. Abdel.

[Patch-Qt4] QWorkArea cleanup

2006-03-11 Thread Abdelrazak Younes
Hello, Could someone please commit this? I would like applied before I the following one which conatains compilation fixes for MacOSX. Thanks in advance, Abdel. PS: Lars, I sent you a private email about this svn account, I don't know if you received it. Index: D:/msys/home/yns/src/lyx-svn

Re: [Patch-Qt4] QWorkArea cleanup

2006-03-10 Thread Abdelrazak Younes
Georg Baum a écrit : Lars Gullik Bjønnes wrote: Georg Baum <[EMAIL PROTECTED]> writes: | The next time I'd prefer it embedded in the patch. Besides that I really | think you should get write access to qt4. I'll arrange for that. Fine, then I prefer that you, Abdel put this in yourself. Less

Re: [Patch-Qt4] QWorkArea cleanup

2006-03-10 Thread Georg Baum
Lars Gullik Bjønnes wrote: > Georg Baum <[EMAIL PROTECTED]> > writes: > | The next time I'd prefer it embedded in the patch. Besides that I really > | think you should get write access to qt4. > > I'll arrange for that. Fine, then I prefer that you, Abdel put this in yourself. Less work for me :

Re: [Patch-Qt4] QWorkArea cleanup

2006-03-10 Thread Lars Gullik Bjønnes
Georg Baum <[EMAIL PROTECTED]> writes: | Abdelrazak Younes wrote: | | > I am afraid you won't see anything by doing a diff because Qt4 version | > is a "merge" of QWorkArea and QContentPane using QAbstractScrollArea. | | OK, I did not know. Then I have nothing against shuffling around. But as |

Re: [Patch-Qt4] QWorkArea cleanup

2006-03-10 Thread Georg Baum
Abdelrazak Younes wrote: > I am afraid you won't see anything by doing a diff because Qt4 version > is a "merge" of QWorkArea and QContentPane using QAbstractScrollArea. OK, I did not know. Then I have nothing against shuffling around. But as long as there are no big changes in a particular qt4 f

Re: [Patch-Qt4] QWorkArea cleanup

2006-03-10 Thread Abdelrazak Younes
Georg Baum a écrit : Abdelrazak Younes wrote: Georg, You would be so kind if you could commit this (even kinder if you test it). This is just a cleanup of QworkArea.[Ch] that I have done when I was looking for the "-mms-bitfield" bug. I have placed all specific stuff (Qt-immodule, X11 and Mac

Re: [Patch-Qt4] QWorkArea cleanup

2006-03-10 Thread Georg Baum
Abdelrazak Younes wrote: > Georg, > > You would be so kind if you could commit this (even kinder if you test > it). This is just a cleanup of QworkArea.[Ch] that I have done when I > was looking for the "-mms-bitfield" bug. > > I have placed all specific stuff (Qt-immodule, X11 and Mac OSX) in a

[Patch-Qt4] QWorkArea cleanup

2006-03-10 Thread Abdelrazak Younes
Georg, You would be so kind if you could commit this (even kinder if you test it). This is just a cleanup of QworkArea.[Ch] that I have done when I was looking for the "-mms-bitfield" bug. I have placed all specific stuff (Qt-immodule, X11 and Mac OSX) in a separate place at the end of QWork