Georg Baum a écrit :
Abdelrazak Younes wrote:
Georg,
You would be so kind if you could commit this (even kinder if you test
it). This is just a cleanup of QworkArea.[Ch] that I have done when I
was looking for the "-mms-bitfield" bug.
I have placed all specific stuff (Qt-immodule, X11 and Mac OSX) in a
separate place at the end of QWorkArea.C. I cannot fix those as I have
no access to linux or Mac.
What does cleanup mean? Only shuffling things around ore more?
A bit more.
Changelog:
QWorkArea.[Ch] cleanup:
- Added private members workWidth_ and workHeight_ in order to make sure
QWorkArea is always able to draw (link to workArea::WorkAreaResize).
- deleted superfluous debugging stuff
- deleted superfluous commented out code.
- placed all specific stuff (Qt-immodule, X11 and Mac OSX) in a separate
place at the end of QWorkArea.C.
- initial support for Wheel mouse (still does not work).
If it is only
the former then I really would like to leave things as is. This allows to
see the real differences qt4 <-> qt3 with a simple diff.
I am afraid you won't see anything by doing a diff because Qt4 version
is a "merge" of QWorkArea and QContentPane using QAbstractScrollArea.
Generally speaking, the port to Qt4 was a bit more involved than classes
and calls renaming. The all point of Qt4 is to bring a clean Model/View
separation so I forecast even greater changes than this one in the
future. IMHO, there is no point in sticking with a "qt2 frontend" alike
code. These are two separate frontends, really, you have to trust me on
this. Maybe some Qt experts in the list could add some weight in what
I've just said?
Beside, I really think that diff style reviewing is only good for small
bug fixing.
> You should also provide a ChangeLog entry if you want this to go in.
Is the above enough?
Abdel.
PS: Sometimes I am not sure I express myself correctly in English; so I
hope that my words are not rude. I am truly thankful for your help in
the Qt4 port.
Georg
