Re: [Patch] reduce the number of call to

2006-06-25 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Michael Gerz <[EMAIL PROTECTED]> writes: | > -updateScrollbar(); | >+ //updateScrollbar(); | > } | > | | Why don't you just remove the line? I don't like uncommented code as | it is supposed to have some meaning. Are you uncertain about the code? Yes. Autho

Re: [Patch] reduce the number of call to

2006-06-25 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > Why don't you just remove the line? I don't like uncommented code as | > it is supposed to have some meaning. Are you uncertain about the | > code? | | I have removed the lines now. Oh, I thought this was the line in the xforms code... which I am

Re: [Patch] reduce the number of call to

2006-06-25 Thread Lars Gullik Bjønnes
Michael Gerz <[EMAIL PROTECTED]> writes: | Abdelrazak Younes wrote: | | > This patch reduce the number of calls to | > BufferView::updateScrollbar() to the bare minimum, that is in | > GuiWorkArea::paintEvent(). All other calls are useless since we make | > sure that the scrollbar is updated if a

Re: [Patch] reduce the number of call to

2006-06-25 Thread Abdelrazak Younes
Michael Gerz wrote: Abdelrazak Younes wrote: This patch reduce the number of calls to BufferView::updateScrollbar() to the bare minimum, that is in GuiWorkArea::paintEvent(). All other calls are useless since we make sure that the scrollbar is updated if and when anything is painted on screen

Re: [Patch] reduce the number of call to

2006-06-25 Thread Michael Gerz
Abdelrazak Younes wrote: This patch reduce the number of calls to BufferView::updateScrollbar() to the bare minimum, that is in GuiWorkArea::paintEvent(). All other calls are useless since we make sure that the scrollbar is updated if and when anything is painted on screen. Index: BufferView

Re: [Patch] reduce the number of call to

2006-06-23 Thread Abdelrazak Younes
Peter Kümmel wrote: Abdelrazak Younes wrote: Hello, One more brick to the wall: 16/17 seconds for UserGuide now. Abdel. Your recent two patches are very interesting. Are they already in your branch? (Wanna see the speedup by myself. :) ) Yes, they are in my branch. By the way look in the

Re: [Patch] reduce the number of call to

2006-06-23 Thread Peter Kümmel
Abdelrazak Younes wrote: > Hello, > > One more brick to the wall: 16/17 seconds for UserGuide now. > > Abdel. > Your recent two patches are very interesting. Are they already in your branch? (Wanna see the speedup by myself. :) ) Peter

Re: [Patch] reduce the number of call to

2006-06-22 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | Hello, | > | | One more brick to the wall: 16/17 seconds for UserGuide now. | > ... and please keep this one out of personal/younes, let's

Re: [Patch] reduce the number of call to

2006-06-22 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | Hello, | > | | One more brick to the wall: 16/17 seconds for UserGuide now. | > This has to be checked/fixed on xform/gtk/qt3 as well. |

Re: [Patch] reduce the number of call to

2006-06-22 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | Hello, | > | | One more brick to the wall: 16/17 seconds for UserGuide now. | > ... and please keep this one out of personal/younes, let's handle | > this | > one dire

Re: [Patch] reduce the number of call to

2006-06-22 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Hello, | | One more brick to the wall: 16/17 seconds for UserGuide now. ... and please keep this one out of personal/younes, let's handle this one direclty in trunk. But this patch depends on my cleanup code already.

Re: [Patch] reduce the number of call to

2006-06-22 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | Hello, | > | | One more brick to the wall: 16/17 seconds for UserGuide now. | > This has to be checked/fixed on xform/gtk/qt3 as well. | | I know and I am afraid of t

Re: [Patch] reduce the number of call to

2006-06-22 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Hello, | | One more brick to the wall: 16/17 seconds for UserGuide now. This has to be checked/fixed on xform/gtk/qt3 as well. I know and I am afraid of the work involved in fixing them. Could we take a decision on

Re: [Patch] reduce the number of call to

2006-06-22 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Hello, | | One more brick to the wall: 16/17 seconds for UserGuide now. ... and please keep this one out of personal/younes, let's handle this one direclty in trunk. -- Lgb

Re: [Patch] reduce the number of call to

2006-06-22 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Hello, | | One more brick to the wall: 16/17 seconds for UserGuide now. This has to be checked/fixed on xform/gtk/qt3 as well. (and the code deleted not just commented out) Also... the backend should not have any concept of scrollbar at all... th

[Patch] reduce the number of call to

2006-06-22 Thread Abdelrazak Younes
Hello, One more brick to the wall: 16/17 seconds for UserGuide now. Abdel. Log: This patch reduce the number of calls to BufferView::updateScrollbar() to the bare minimum, that is in GuiWorkArea::paintEvent(). All other calls are useless since we make sure that the scrollbar is updated if a