Re: [Patch] reduce the number of call to

[Abdelrazak Younes]

Michael Gerz wrote:

Abdelrazak Younes wrote:

This patch reduce the number of calls to BufferView::updateScrollbar() to the bare minimum, that is in GuiWorkArea::paintEvent(). All other calls are useless since we make sure that the scrollbar is updated if and when anything is painted on screen.

Index: BufferView_pimpl.C
===================================================================
--- BufferView_pimpl.C    (revision 14178)
+++ BufferView_pimpl.C    (working copy)
@@ -458,7 +458,7 @@
    // Reset the "Formatting..." message
    owner_->clearMessage();

-    updateScrollbar();
+    //updateScrollbar();
}

Why don't you just remove the line? I don't like uncommented code as it is supposed to have some meaning. Are you uncertain about the code?

I have removed the lines now.

Abdel.