Re: [Patch] Rewrite of FormsFileDialog

2005-03-02 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > [EMAIL PROTECTED] (Lars Gullik Bjønnes) > writes: > > | This is what it looks like simplifed and rewritten to use > | boost.filesystem. >> > | I have not changed the visual apparence of the dialog, so there are > | one widget too many on it currently (unused). > > Ju

Re: [Patch] Rewrite of FormsFileDialog

2005-03-01 Thread Lars Gullik Bjønnes
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | This is what it looks like simplifed and rewritten to use | boost.filesystem. > | I have not changed the visual apparence of the dialog, so there are | one widget too many on it currently (unused). Just a note that the now unused widget really sho

Re: [Patch] Rewrite of FormsFileDialog

2005-01-31 Thread Lars Gullik Bjønnes
Asger Ottar Alstrup <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: >> I am waiting for comments on it... and you might not be too happy > | I'm happy with it. > >> with it either since I have not implemented the functions in fs_extras >> for Win. >> is_readable >> is_writable >> is_reado

Re: [Patch] Rewrite of FormsFileDialog

2005-01-31 Thread Asger Ottar Alstrup
Lars Gullik Bjønnes wrote: I am waiting for comments on it... and you might not be too happy I'm happy with it. with it either since I have not implemented the functions in fs_extras for Win. is_readable is_writable is_readonly and a new version of copy_file. I'll implement that, provided Elias doe

Re: [Patch] Rewrite of FormsFileDialog

2005-01-31 Thread Lars Gullik Bjønnes
Asger Ottar Alstrup <[EMAIL PROTECTED]> writes: | When will you be committing your boost filesystem stuff? > | I'm kind of waiting for it... I'd like to roll a new patch today, as | my last day of paternity leave, and I'd like that stuff to be in there. I am waiting for comments on it... and you

Re: [Patch] Rewrite of FormsFileDialog

2005-01-31 Thread Asger Ottar Alstrup
When will you be committing your boost filesystem stuff? I'm kind of waiting for it... I'd like to roll a new patch today, as my last day of paternity leave, and I'd like that stuff to be in there. Regards, Asger

Re: [Patch] Rewrite of FormsFileDialog

2005-01-31 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: >> Hey... you left me just as clue-less. What is "I-P"? > | My bad. I was tryig to remember a Jürgen Vigna favourite :-P. See the very | last item in http://members.aol.com/bearpage/smileys.htm ":-P nya!" Is that some ki

Re: [Patch] Rewrite of FormsFileDialog

2005-01-31 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > Hey... you left me just as clue-less. What is "I-P"? My bad. I was tryig to remember a Jürgen Vigna favourite :-P. See the very last item in http://members.aol.com/bearpage/smileys.htm > "Here! Have one for the toad." Huh? -- Angus

Re: [Patch] Rewrite of FormsFileDialog

2005-01-30 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: >> Hmm da mm... I have no idea what "I-P" is... are you goading me? > | I never goad. I'm the diplomat around here, apparently. Hey... you left me just as clue-less. What is "I-P"? "Here! Have one for the toad." --

Re: [Patch] Rewrite of FormsFileDialog

2005-01-30 Thread Angus Leeming
Lars Gullik Bjønnes wrote: Hmm da mm... I have no idea what "I-P" is... are you goading me? I never goad. I'm the diplomat around here, apparently. Angus

Re: [Patch] Rewrite of FormsFileDialog

2005-01-30 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: >> btw. We have lots and lots of filesystem-race conditions. Most often >> these does not matter much, but we should plan to get rid of them... >> fs::exists(foo) && fs::is_directory(foo) is actually racy and can >> result in a

Re: [Patch] Rewrite of FormsFileDialog

2005-01-30 Thread Angus Leeming
Martin Vermeer wrote: What's to comment? Fantastic! The existing code is a pile of ancient, fossilized poo. Just what I thought, reading this as a complete non-expert. Of interest to paleoentologists but crap to the rest of us. Surely you mean "palaeoentomologists"? As in old bugs? Maybe. But I

Re: [Patch] Rewrite of FormsFileDialog

2005-01-30 Thread Angus Leeming
Lars Gullik Bjønnes wrote: btw. We have lots and lots of filesystem-race conditions. Most often these does not matter much, but we should plan to get rid of them... fs::exists(foo) && fs::is_directory(foo) is actually racy and can result in an unwanted exeption since foo can have been deleted betwe

Re: [Patch] Rewrite of FormsFileDialog

2005-01-30 Thread Martin Vermeer
On Sun, Jan 30, 2005 at 03:26:12PM +, Angus Leeming wrote: > >Please comment. > > What's to comment? Fantastic! The existing code is a pile of ancient, > fossilized poo. Just what I thought, reading this as a complete non-expert. > Of interest to paleoentologists but crap to the rest of u

Re: [Patch] Rewrite of FormsFileDialog

2005-01-30 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: >> This is what it looks like simplifed and rewritten to use >> boost.filesystem. >> I have not changed the visual apparence of the dialog, so there are >> one widget too many on it currently (unused). >> Please comment. > | Wh

Re: [Patch] Rewrite of FormsFileDialog

2005-01-30 Thread Angus Leeming
Lars Gullik Bjønnes wrote: This is what it looks like simplifed and rewritten to use boost.filesystem. I have not changed the visual apparence of the dialog, so there are one widget too many on it currently (unused). Please comment. What's to comment? Fantastic! The existing code is a pile of ancie

[Patch] Rewrite of FormsFileDialog

2005-01-29 Thread Lars Gullik Bjønnes
This is what it looks like simplifed and rewritten to use boost.filesystem. I have not changed the visual apparence of the dialog, so there are one widget too many on it currently (unused). Please comment. Index: FormFiledialog.C =