Re: [Patch] Re: [patch] key event queue

2005-06-06 Thread Martin Vermeer
On Mon, 2005-06-06 at 15:17, Lars Gullik Bjønnes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > I am fine with this. > (I'd better be...) Done. - Martin signature.asc Description: This is a digitally signed message part

Re: [Patch] Re: [patch] key event queue

2005-06-06 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: I am fine with this. (I'd better be...) -- Lgb

Re: [Patch] Re: [patch] key event queue

2005-06-06 Thread Martin Vermeer
On Mon, 2005-06-06 at 11:46, Lars Gullik Bjønnes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > | On Wed, Jun 01, 2005 at 03:12:05PM +0300, Martin Vermeer wrote: > >> On Wed, Jun 01, 2005 at 01:31:55PM +0200, Lars Gullik Bjønnes wrote: > >> > Martin Vermeer <[EMAIL PROTECTED]> writes: > >

Re: [Patch] Re: [patch] key event queue

2005-06-06 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: | On Wed, Jun 01, 2005 at 03:12:05PM +0300, Martin Vermeer wrote: >> On Wed, Jun 01, 2005 at 01:31:55PM +0200, Lars Gullik Bjønnes wrote: >> > Martin Vermeer <[EMAIL PROTECTED]> writes: > | ... | >> OK, that settles it then for me: put in the event que

Re: [Patch] Re: [patch] key event queue

2005-06-05 Thread Martin Vermeer
On Wed, Jun 01, 2005 at 03:12:05PM +0300, Martin Vermeer wrote: > On Wed, Jun 01, 2005 at 01:31:55PM +0200, Lars Gullik Bjønnes wrote: > > Martin Vermeer <[EMAIL PROTECTED]> writes: ... > OK, that settles it then for me: put in the event queue and reverse the > new stuff in workAreaKeyPress to

Re: [Patch] Re: [patch] key event queue

2005-06-03 Thread Helge Hafting
Lars Gullik Bjønnes wrote: Martin Vermeer <[EMAIL PROTECTED]> writes: [...] | No, I meant that just the other way around. The fact that fast mouse | scrolling exists allows us to make keyboard scrolling slow... as your | event queue for ex. does. The slowness will drive people to use the

Re: [Patch] Re: [patch] key event queue

2005-06-01 Thread Martin Vermeer
On Wed, Jun 01, 2005 at 01:31:55PM +0200, Lars Gullik Bjønnes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > | On Wed, Jun 01, 2005 at 10:55:24AM +0200, Lars Gullik Bjønnes wrote: > >> Martin Vermeer <[EMAIL PROTECTED]> writes: > > > | ... > | > >> What the event queue accomplishes is t

Re: [Patch] Re: [patch] key event queue

2005-06-01 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: | On Wed, Jun 01, 2005 at 10:55:24AM +0200, Lars Gullik Bjønnes wrote: >> Martin Vermeer <[EMAIL PROTECTED]> writes: > | ... | >> What the event queue accomplishes is to say that: "We do not allow >> auto-repeat events to queue up faster than we are abl

Re: [Patch] Re: [patch] key event queue

2005-06-01 Thread Martin Vermeer
On Wed, Jun 01, 2005 at 10:55:24AM +0200, Lars Gullik Bjønnes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: ... > What the event queue accomplishes is to say that: "We do not allow > auto-repeat events to queue up faster than we are able to handle > them." How does your event queue affect

Re: [Patch] Re: [patch] key event queue

2005-06-01 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: >> how do you know when you get there? > | 1) You go to almost the right place using key repeat and the scrollbar. > | 2) You tap the PgDn key so it doesn't repeat, until you are there. > | The same as aiming a telescope: release fine motion, swing to the

Re: [Patch] Re: [patch] key event queue

2005-06-01 Thread Jean-Marc Lasgouttes
Martin> + if (s == "Up" || s == "Down" || s == "Left" || s == "Right") Martin> + screen().showCursor(*bv_); Of course testing directly keys is not acceptable, but we could imagine to have a LyXAction flag that tells whether an action requires a screen update... JMarc

Re: [Patch] Re: [patch] key event queue

2005-06-01 Thread Martin Vermeer
On Wed, 2005-06-01 at 11:55, Lars Gullik Bjønnes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > | On Wed, 2005-06-01 at 11:05, Lars Gullik Bjønnes wrote: > >> Martin Vermeer <[EMAIL PROTECTED]> writes: > >> > >> >> Ok. I did my tests. > >> >> > >> >> I must admit that I now find it unu

Re: [Patch] Re: [patch] key event queue

2005-06-01 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: | On Wed, 2005-06-01 at 11:05, Lars Gullik Bjønnes wrote: >> Martin Vermeer <[EMAIL PROTECTED]> writes: >> >> >> Ok. I did my tests. >> >> >> >> I must admit that I now find it unusable. No feedback on screen when >> >> using cursor keys for movement (o

Re: [Patch] Re: [patch] key event queue

2005-06-01 Thread Martin Vermeer
On Wed, 2005-06-01 at 11:05, Lars Gullik Bjønnes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > >> Ok. I did my tests. > >> > >> I must admit that I now find it unusable. No feedback on screen when > >> using cursor keys for movement (on auto-repeat) > >> > >> Same with PageDown/PageUp.

Re: [Patch] Re: [patch] key event queue

2005-06-01 Thread Martin Vermeer
On Tue, May 31, 2005 at 10:38:35PM +0200, Lars Gullik Bjønnes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > | On Tue, 2005-05-31 at 09:55, Lars Gullik Bjønnes wrote: > >> Martin Vermeer <[EMAIL PROTECTED]> writes: > >> > >> >> So it seems to fix most problems we have and feels uniforml

Re: [Patch] Re: [patch] key event queue

2005-06-01 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: >> Ok. I did my tests. >> >> I must admit that I now find it unusable. No feedback on screen when >> using cursor keys for movement (on auto-repeat) >> >> Same with PageDown/PageUp. (except from the scrollbar) > | Which I think is good enough. | I don't

Re: [Patch] Re: [patch] key event queue

2005-06-01 Thread Martin Vermeer
On Tue, May 31, 2005 at 10:38:35PM +0200, Lars Gullik Bjønnes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > | On Tue, 2005-05-31 at 09:55, Lars Gullik Bjønnes wrote: > >> Martin Vermeer <[EMAIL PROTECTED]> writes: > >> > >> >> So it seems to fix most problems we have and feels uniforml

Re: [Patch] Re: [patch] key event queue

2005-05-31 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: | On Tue, 2005-05-31 at 09:55, Lars Gullik Bjønnes wrote: >> Martin Vermeer <[EMAIL PROTECTED]> writes: >> >> >> So it seems to fix most problems we have and feels uniformly better that >> >> what we have right now? If so... >> > >> | Yes, I believe so.

Re: [Patch] Re: [patch] key event queue

2005-05-31 Thread Martin Vermeer
On Tue, 2005-05-31 at 09:55, Lars Gullik Bjønnes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > >> So it seems to fix most problems we have and feels uniformly better that > >> what we have right now? If so... > > > | Yes, I believe so. > > > | Therefore I will commit the attached, if no

Re: [Patch] Re: [patch] key event queue

2005-05-30 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: >> So it seems to fix most problems we have and feels uniformly better that >> what we have right now? If so... > | Yes, I believe so. > | Therefore I will commit the attached, if no new objections come up. I | have somewhat thoroughly tested this with t

Re: [Patch] Re: [patch] key event queue

2005-05-30 Thread Martin Vermeer
On Mon, 2005-05-30 at 16:01, Andre Poenitz wrote: > On Mon, May 30, 2005 at 12:15:19PM +0300, Martin Vermeer wrote: > > > How "asynchrounous" is Martin's approach, i.e. how long will LyX be busy > > > after a user released PageDown? > > > > The time it takes to render one screen (or slightly over)

Re: [Patch] Re: [patch] key event queue

2005-05-30 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > | Lars> Key events are not coalesced (or have you dont something I have | Lars> not noticed?) without my patch. Sure my patch also does not do | Lars> it, but it could... Note that p

Re: [Patch] Re: [patch] key event queue

2005-05-30 Thread Andre Poenitz
On Mon, May 30, 2005 at 12:15:19PM +0300, Martin Vermeer wrote: > > How "asynchrounous" is Martin's approach, i.e. how long will LyX be busy > > after a user released PageDown? > > The time it takes to render one screen (or slightly over). I see no > large backlogs. So it seems to fix most proble

Re: [Patch] Re: [patch] key event queue

2005-05-30 Thread Martin Vermeer
On Mon, 2005-05-30 at 12:50, Lars Gullik Bjønnes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > | On Mon, 2005-05-30 at 10:56, Lars Gullik Bjønnes wrote: > >> Martin Vermeer <[EMAIL PROTECTED]> writes: > >> > >> | On Sat, May 28, 2005 at 12:12:07AM +0200, Lars Gullik Bjønnes wrote: > >

Re: [Patch] Re: [patch] key event queue

2005-05-30 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: | On Mon, 2005-05-30 at 12:46, Lars Gullik Bjønnes wrote: >> Martin Vermeer <[EMAIL PROTECTED]> writes: >> >> >> How "asynchrounous" is Martin's approach, i.e. how long will LyX be busy >> >> after a user released PageDown? >> > >> | The time it takes to

Re: [Patch] Re: [patch] key event queue

2005-05-30 Thread Martin Vermeer
On Mon, 2005-05-30 at 12:46, Lars Gullik Bjønnes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > >> How "asynchrounous" is Martin's approach, i.e. how long will LyX be busy > >> after a user released PageDown? > > > | The time it takes to render one screen (or slightly over). I see no > |

Re: [Patch] Re: [patch] key event queue

2005-05-30 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > | Lars> Key events are not coalesced (or have you dont something I have | Lars> not noticed?) without my patch. Sure my patch also does not do | Lars> it, but it could... Note that p

Re: [Patch] Re: [patch] key event queue

2005-05-30 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> Key events are not coalesced (or have you dont something I have Lars> not noticed?) without my patch. Sure my patch also does not do Lars> it, but it could... Note that pruning is only done if the screen Lars> update cannot keep

Re: [Patch] Re: [patch] key event queue

2005-05-30 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: | On Mon, 2005-05-30 at 10:56, Lars Gullik Bjønnes wrote: >> Martin Vermeer <[EMAIL PROTECTED]> writes: >> >> | On Sat, May 28, 2005 at 12:12:07AM +0200, Lars Gullik Bjønnes wrote: >> >> | Actually I have now had time to think about this for two weeks, a

Re: [Patch] Re: [patch] key event queue

2005-05-30 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: >> How "asynchrounous" is Martin's approach, i.e. how long will LyX be busy >> after a user released PageDown? > | The time it takes to render one screen (or slightly over). I see no | large backlogs. Try that on a slower computer... -- Lgb

Re: [Patch] Re: [patch] key event queue

2005-05-30 Thread Martin Vermeer
On Mon, 2005-05-30 at 11:49, Andre Poenitz wrote: > On Mon, May 30, 2005 at 09:56:06AM +0200, Lars Gullik Bjønnes wrote: > > | I have the feeling that pruning repeat key events is not wrong in > > | principle, but at best not needed. Without it, you know precisely > > | (under my scheme) that keepi

Re: [Patch] Re: [patch] key event queue

2005-05-30 Thread Martin Vermeer
On Mon, 2005-05-30 at 10:56, Lars Gullik Bjønnes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > | On Sat, May 28, 2005 at 12:12:07AM +0200, Lars Gullik Bjønnes wrote: > >> | Actually I have now had time to think about this for two weeks, and my > >> | considered opinion is a bit different

Re: [Patch] Re: [patch] key event queue

2005-05-30 Thread Andre Poenitz
On Mon, May 30, 2005 at 09:56:06AM +0200, Lars Gullik Bjønnes wrote: > | I have the feeling that pruning repeat key events is not wrong in > | principle, but at best not needed. Without it, you know precisely > | (under my scheme) that keeping the PgDown key down for 0.5 secs will get > | you 10 sc

Re: [Patch] Re: [patch] key event queue

2005-05-30 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: | On Sun, May 29, 2005 at 09:58:22PM +0300, Martin Vermeer wrote: >> On Sat, May 28, 2005 at 12:12:07AM +0200, Lars Gullik Bjønnes wrote: | >> > | +inline flags operator|(flags const f, flags const g) >> > | +{ >> > | +int const intf(static_ca

Re: [Patch] Re: [patch] key event queue

2005-05-30 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: | On Sat, May 28, 2005 at 12:12:07AM +0200, Lars Gullik Bjønnes wrote: >> | Actually I have now had time to think about this for two weeks, and my >> | considered opinion is a bit different... >> >> What you write belowe seems very sane. But I think that

Re: [Patch] Re: [patch] key event queue

2005-05-29 Thread Martin Vermeer
On Sun, May 29, 2005 at 09:58:22PM +0300, Martin Vermeer wrote: > On Sat, May 28, 2005 at 12:12:07AM +0200, Lars Gullik Bjønnes wrote: > > | +inline flags operator|(flags const f, flags const g) > > | +{ > > | + int const intf(static_cast(f)); > > | + int const intg(static_cast(g)); > > | + ret

Re: [Patch] Re: [patch] key event queue

2005-05-29 Thread Martin Vermeer
On Sat, May 28, 2005 at 12:12:07AM +0200, Lars Gullik Bjønnes wrote: > | Actually I have now had time to think about this for two weeks, and my > | considered opinion is a bit different... > > What you write belowe seems very sane. But I think that my keyevent > queue is still needed? (but to fix

Re: [Patch] Re: [patch] key event queue

2005-05-27 Thread Lars Gullik Bjønnes
| Actually I have now had time to think about this for two weeks, and my | considered opinion is a bit different... What you write belowe seems very sane. But I think that my keyevent queue is still needed? (but to fix a different problem) | +inline flags operator|(flags const f, flags const g)

Re: [Patch] Re: [patch] key event queue

2005-05-27 Thread Martin Vermeer
On Fri, May 27, 2005 at 04:28:32PM -0400, Bennett Helm wrote: > On May 27, 2005, at 2:59 PM, Martin Vermeer wrote: > > >Actually I have now had time to think about this for two weeks, and my > >considered opinion is a bit different... > > This patch fixes problems on the Mac with dropping charact

Re: [Patch] Re: [patch] key event queue

2005-05-27 Thread Bennett Helm
On May 27, 2005, at 2:59 PM, Martin Vermeer wrote: Actually I have now had time to think about this for two weeks, and my considered opinion is a bit different... This patch fixes problems on the Mac with dropping characters and with reordering characters. Also, scrolling feels much better.

[Patch] Re: [patch] key event queue

2005-05-27 Thread Martin Vermeer
On Thu, May 19, 2005 at 09:46:27AM +0200, Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | On Thu, May 12, 2005 at 06:47:50PM +0200, Lars Gullik Bjønnes wrote: > >> this is kindo a proof-of-concept. > > > | Is there a specific reason this queue is in the frontend and no

[Discussion patch :-)] Re: [patch] key event queue

2005-05-15 Thread Martin Vermeer
On Sun, May 15, 2005 at 07:11:02PM +0200, Helge Hafting wrote: > On Sun, May 15, 2005 at 05:09:39PM +0300, Martin Vermeer wrote: > > Lars, > > > > Now that I have had some time to think it over, I am more and more > > inclined to suspect that there is something to my dark fear. > > > > As I under