Re: [Additional patch] Re: [Patch] Fix outline crash for non-ToC tables

2006-04-21 Thread Martin Vermeer
On Wed, Apr 19, 2006 at 07:12:14PM +0200, Abdelrazak Younes wrote: > Martin Vermeer a écrit : > >On Wed, Apr 19, 2006 at 04:25:11PM +0200, Abdelrazak Younes wrote: > >>Martin Vermeer a écrit : > >>>On Wed, 2006-04-19 at 14:32 +0200, Abdelrazak Younes wrote: > > > >... > > > >Actually the _crash_ is

Re: [Patch] Fix outline crash for non-ToC tables

2006-04-19 Thread Martin Vermeer
On Wed, Apr 19, 2006 at 04:56:05PM +0300, Martin Vermeer wrote: > On Wed, 2006-04-19 at 14:32 +0200, Abdelrazak Younes wrote: > > Martin Vermeer a écrit : > > > On Wed, 2006-04-19 at 10:28 +0200, Abdelrazak Younes wrote: > > ... > > > >> Martin, please have a look at the new ControlToc::canOutlin

Re: [Additional patch] Re: [Patch] Fix outline crash for non-ToC tables

2006-04-19 Thread Martin Vermeer
On Wed, Apr 19, 2006 at 07:43:44PM +0300, Martin Vermeer wrote: > On Wed, Apr 19, 2006 at 04:25:11PM +0200, Abdelrazak Younes wrote: > > Martin Vermeer a écrit : > > >On Wed, 2006-04-19 at 14:32 +0200, Abdelrazak Younes wrote: > > ... > > Actually the _crash_ is due to the paragraph being not in

Re: [Additional patch] Re: [Patch] Fix outline crash for non-ToC tables

2006-04-19 Thread Martin Vermeer
On Wed, Apr 19, 2006 at 07:12:14PM +0200, Abdelrazak Younes wrote: > Martin Vermeer a écrit : > >On Wed, Apr 19, 2006 at 04:25:11PM +0200, Abdelrazak Younes wrote: > >>Martin Vermeer a écrit : > >>>On Wed, 2006-04-19 at 14:32 +0200, Abdelrazak Younes wrote: > > > >... > > > >Actually the _crash_ is

Re: [Additional patch] Re: [Patch] Fix outline crash for non-ToC tables

2006-04-19 Thread Abdelrazak Younes
Martin Vermeer a écrit : On Wed, Apr 19, 2006 at 04:25:11PM +0200, Abdelrazak Younes wrote: Martin Vermeer a écrit : On Wed, 2006-04-19 at 14:32 +0200, Abdelrazak Younes wrote: ... Actually the _crash_ is due to the paragraph being not in the main lyxtext. It is fixed by the attached patch,

[Additional patch] Re: [Patch] Fix outline crash for non-ToC tables

2006-04-19 Thread Martin Vermeer
On Wed, Apr 19, 2006 at 04:25:11PM +0200, Abdelrazak Younes wrote: > Martin Vermeer a écrit : > >On Wed, 2006-04-19 at 14:32 +0200, Abdelrazak Younes wrote: ... Actually the _crash_ is due to the paragraph being not in the main lyxtext. It is fixed by the attached patch, which also handles the ca

Re: [Patch] Fix outline crash for non-ToC tables

2006-04-19 Thread Abdelrazak Younes
Martin Vermeer a écrit : On Wed, 2006-04-19 at 14:32 +0200, Abdelrazak Younes wrote: [...] + string const & type = toc::getType(controller().params().getCmdName()); Did you test this? I mean are you sure the return type is the same as the one selected in the type combo? (I haven't check

Re: [Patch] Fix outline crash for non-ToC tables

2006-04-19 Thread Martin Vermeer
On Wed, 2006-04-19 at 14:32 +0200, Abdelrazak Younes wrote: > Martin Vermeer a écrit : > > On Wed, 2006-04-19 at 10:28 +0200, Abdelrazak Younes wrote: ... > >> Martin, please have a look at the new ControlToc::canOutline() method. > >> Im 1.5svn you get a crash if you try to use outline with fig

Re: [Patch] Fix outline crash for non-ToC tables

2006-04-19 Thread Abdelrazak Younes
Martin Vermeer a écrit : On Wed, 2006-04-19 at 10:28 +0200, Abdelrazak Younes wrote: Martin Vermeer a écrit : Attached, trying to take into account discussions since. OK to commit? No document format change, and I don't expect the user base will want to wait until 1.5 ;-) Martin, please have a

[Patch] Fix outline crash for non-ToC tables

2006-04-19 Thread Martin Vermeer
On Wed, 2006-04-19 at 10:28 +0200, Abdelrazak Younes wrote: > Martin Vermeer a écrit : > > Attached, trying to take into account discussions since. > > > > OK to commit? No document format change, and I don't expect the user > > base will want to wait until 1.5 ;-) > > Martin, please have a look