Re: [Additional patch] Re: [Patch] Fix outline crash for non-ToC tables

[Martin Vermeer]

On Wed, Apr 19, 2006 at 07:12:14PM +0200, Abdelrazak Younes wrote:
> Martin Vermeer a écrit :
> >On Wed, Apr 19, 2006 at 04:25:11PM +0200, Abdelrazak Younes wrote:
> >>Martin Vermeer a écrit :
> >>>On Wed, 2006-04-19 at 14:32 +0200, Abdelrazak Younes wrote:
> >
> >...
> >
> >Actually the _crash_ is due to the paragraph being not in the main
> >lyxtext. It is fixed by the attached patch, which also handles the case
> >of, say, a section header inside a box inset. With this patch, no crash
> >will happen, though outlining will malfunction for this header. 
> 
> I guess this is because you use ParagraphList::iterator instead of 
> ParIterator in toc.C:outline()
> 
> >Still I think that my earlier patch is needed too... cleaner to have the
> >buttons disabled for non-ToC.
> 
> Yes.

I just committed the earlier patch:

        Grey out outlining movement buttons for non-ToC

        * qt2/QTocDialog.[Ch]: Add enableButtons

        * qt2/QToc.[Ch]
        (QToc::build_dialog):
        (QToc::updateType):
        (QToc::updateToc):
        (QToc::updateToc):
        (QToc::set_depth): Change update logic


- Martin
 

pgpLO4z6HxCnO.pgp
Description: PGP signature