Re: [Patch] Fix for Numbering Symbol Direction in RTL Paragraphs

2009-01-12 Thread Jean-Marc Lasgouttes
Abdelrazak Younes writes: > Or even three if this is a bidi document (eg: Hebrew/English with a > French UI). In general for stuff like this LyX uses the language of > current paragraph... I hope this is also true for numbering. I thought it was rather the language of the document... JMarc

Re: [Patch] Fix for Numbering Symbol Direction in RTL Paragraphs

2009-01-12 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: Would be nice to do the same for Arabic and Farsi. Drop a note to our Arabic translator (or just do it). Done. Abdel.

Re: [Patch] Fix for Numbering Symbol Direction in RTL Paragraphs

2009-01-12 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > Would be nice to do the same for Arabic and Farsi. Drop a note to our Arabic translator (or just do it). For Farsi, we have no localization. Jürgen

Re: [Patch] Fix for Numbering Symbol Direction in RTL Paragraphs

2009-01-12 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Guy Rutenberg wrote: I've altered the he.po file and it worked. I've attached a patch of the changes. It's in (branch and trunk). Would be nice to do the same for Arabic and Farsi. Abdel.

Re: [Patch] Fix for Numbering Symbol Direction in RTL Paragraphs

2009-01-12 Thread Jürgen Spitzmüller
Guy Rutenberg wrote: > I've altered the he.po file and it worked. I've attached a patch of the > changes. It's in (branch and trunk). Jürgen

Re: [Patch] Fix for Numbering Symbol Direction in RTL Paragraphs

2009-01-12 Thread Abdelrazak Younes
Guy Rutenberg wrote: Hi, On Mon, Jan 12, 2009 at 12:16 PM, Abdelrazak Younes > wrote: Jean-Marc Lasgouttes wrote: For stuff like this, LyX uses the language of the document, not of the interface. Actually, LyX uses (at least) two localizatio

Re: [Patch] Fix for Numbering Symbol Direction in RTL Paragraphs

2009-01-12 Thread Guy Rutenberg
Hi, On Mon, Jan 12, 2009 at 12:16 PM, Abdelrazak Younes wrote: > Jean-Marc Lasgouttes wrote: > >> >> For stuff like this, LyX uses the language of the document, not of the >> interface. Actually, LyX uses (at least) two localizations in parallel. >> >> > > Or even three if this is a bidi documen

Re: [Patch] Fix for Numbering Symbol Direction in RTL Paragraphs

2009-01-12 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Guy Rutenberg" writes: There are two reasons that I think are worth putting it in the C++ code: 1. Many users who write documents in Hebrew are using the English interface of LyX, so that changes in he.po will not affect them. For stuff like this, LyX use

Re: [Patch] Fix for Numbering Symbol Direction in RTL Paragraphs

2009-01-12 Thread Jean-Marc Lasgouttes
"Guy Rutenberg" writes: > There are two reasons that I think are worth putting it in the C++ code: > > 1. Many users who write documents in Hebrew are using the English interface > of LyX, so that changes in he.po will not affect them. For stuff like this, LyX uses the language of the document, n

Re: [Patch] Fix for Numbering Symbol Direction in RTL Paragraphs

2009-01-12 Thread Guy Rutenberg
Hi Martin, On Mon, Jan 12, 2009 at 10:37 AM, Martin Vermeer wrote: > > Is this the right place to do it in? I'm honestly asking. Isn't this > something that can be done by localization in he.po and should not be > in the C++ code base? What is the reason for doing it like this? > There are two r

Re: [Patch] Fix for Numbering Symbol Direction in RTL Paragraphs

2009-01-12 Thread Martin Vermeer
On Mon, 12 Jan 2009 08:55:22 +0200 Guy Rutenberg wrote: > Hi, > > When writing a paragraph with an RTL language (I checked with Hebrew, but it > should also happen with Arabic), and adding numbered list, the symbols are > shown in the wrong order. I mean by that, that the dot comes before the >

[Patch] Fix for Numbering Symbol Direction in RTL Paragraphs

2009-01-11 Thread Guy Rutenberg
Hi, When writing a paragraph with an RTL language (I checked with Hebrew, but it should also happen with Arabic), and adding numbered list, the symbols are shown in the wrong order. I mean by that, that the dot comes before the numbering symbol instead of after it. The patch checks whether we are