Re: Patch for 2218 (Re: [Patch] Fix for 2212: First change is skipped in "Merge changes..." dialog)

2006-02-16 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> No, it's an entirely different kind of problem... generals are Martin> always fighting the last war ;-) If it works, I love it ! JMarc

Patch for 2218 (Re: [Patch] Fix for 2212: First change is skipped in "Merge changes..." dialog)

2006-02-16 Thread Martin Vermeer
On Tue, 2006-02-14 at 20:19 +0200, Martin Vermeer wrote: > On Tue, Feb 14, 2006 at 05:40:39PM +0100, Jean-Marc Lasgouttes wrote: > > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: ... > > Could you take a look at the spellchecker code and see if you can > > modify it in the same wa

Re: [Patch] Fix for 2212: First change is skipped in "Merge changes..." dialog

2006-02-15 Thread Jean-Marc Lasgouttes
> "John" == John Spray <[EMAIL PROTECTED]> writes: John> By the way, I wouldn't have been aware of this at all if I John> hadn't been reading the list quite thoroughly lately. Perhaps it John> would be a good idea to have some way of flagging any changes John> which require work on the fronten

Re: [Patch] Fix for 2212: First change is skipped in "Merge changes..." dialog

2006-02-15 Thread Martin Vermeer
On Wed, 2006-02-15 at 10:10 +0100, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> Should we aim at replacing this stuff by an interface to > Martin> Enchant? > > Martin> http://www.abisource.com/projects/enchant/ > > Sure, enchant looks ver

Re: [Patch] Fix for 2212: First change is skipped in "Merge changes..." dialog

2006-02-15 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> Should we aim at replacing this stuff by an interface to Martin> Enchant? Martin> http://www.abisource.com/projects/enchant/ Sure, enchant looks very nice, but it is not going to replace ControlSpellchecker, is it? I thought it

Re: [Patch] Fix for 2212: First change is skipped in "Merge changes..." dialog

2006-02-14 Thread Martin Vermeer
On Tue, Feb 14, 2006 at 08:07:36PM +, John Spray wrote: > Am Dienstag, den 14.02.2006, 18:33 +0200 schrieb Martin Vermeer: > > > Executive summary: my previous patch for this is not necessary > > > > But did you test this together with my fix for 2212, i.e., including my > > changes to BufferV

Re: [Patch] Fix for 2212: First change is skipped in "Merge changes..." dialog

2006-02-14 Thread John Spray
Am Dienstag, den 14.02.2006, 18:33 +0200 schrieb Martin Vermeer: > > Executive summary: my previous patch for this is not necessary > > But did you test this together with my fix for 2212, i.e., including my > changes to BufferView_pimpl.C? This changes the logic. You should _not_ > call controlle

Re: [Patch] Fix for 2212: First change is skipped in "Merge changes..." dialog

2006-02-14 Thread John Levon
On Tue, Feb 14, 2006 at 08:19:33PM +0200, Martin Vermeer wrote: > It looks like a similar thing is happening... not nice, as we would have > to simultaneously change front end code, controller code and code for > three different spell checkers. > > Should we aim at replacing this stuff by an inte

Re: [Patch] Fix for 2212: First change is skipped in "Merge changes..." dialog

2006-02-14 Thread Martin Vermeer
On Tue, Feb 14, 2006 at 05:40:39PM +0100, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> But did you test this together with my fix for 2212, i.e., > Martin> including my changes to BufferView_pimpl.C? This changes the > Martin> logic. You sh

Re: [Patch] Fix for 2212: First change is skipped in "Merge changes..." dialog

2006-02-14 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> But did you test this together with my fix for 2212, i.e., Martin> including my changes to BufferView_pimpl.C? This changes the Martin> logic. You should _not_ call controller().find() in update. Martin> That's precisely the faul

Re: [Patch] Fix for 2212: First change is skipped in "Merge changes..." dialog

2006-02-14 Thread Martin Vermeer
On Tue, Feb 14, 2006 at 04:07:44PM +, John Spray wrote: > Am Dienstag, den 14.02.2006, 17:14 +0200 schrieb Martin Vermeer: > > > Let me check that I understand the logic correctly: > > > When we first show the dialog, if controller.changed() returns true then > > > there are changes to be merge

Re: [Patch] Fix for 2212: First change is skipped in "Merge changes..." dialog

2006-02-14 Thread John Spray
Am Dienstag, den 14.02.2006, 17:14 +0200 schrieb Martin Vermeer: > > Let me check that I understand the logic correctly: > > When we first show the dialog, if controller.changed() returns true then > > there are changes to be merged, and if it returns false then there are > > no changes to be merge

Re: [Patch] Fix for 2212: First change is skipped in "Merge changes..." dialog

2006-02-14 Thread Martin Vermeer
On Tue, Feb 14, 2006 at 01:58:10PM +0100, Jean-Marc Lasgouttes wrote: > > "John" == John Spray <[EMAIL PROTECTED]> writes: > > >> Attached what is needed to fix it for xforms also. > > John> And here's one for gtk that depends on the same change to the > John> controller. > > Very good. > >

Re: [Patch] Fix for 2212: First change is skipped in "Merge changes..." dialog

2006-02-14 Thread Martin Vermeer
On Tue, Feb 14, 2006 at 12:20:41PM +, John Spray wrote: > Am Dienstag, den 14.02.2006, 14:00 +0200 schrieb Martin Vermeer: > > On Mon, 2006-02-13 at 23:16 +0100, Jean-Marc Lasgouttes wrote: > > > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > > > > > Martin> Attached, please

Re: [Patch] Fix for 2212: First change is skipped in "Merge changes..." dialog

2006-02-14 Thread Jean-Marc Lasgouttes
> "John" == John Spray <[EMAIL PROTECTED]> writes: >> Attached what is needed to fix it for xforms also. John> And here's one for gtk that depends on the same change to the John> controller. Very good. John> Let me check that I understand the logic correctly: When we John> first show the di

Re: [Patch] Fix for 2212: First change is skipped in "Merge changes..." dialog

2006-02-14 Thread John Spray
Am Dienstag, den 14.02.2006, 14:00 +0200 schrieb Martin Vermeer: > On Mon, 2006-02-13 at 23:16 +0100, Jean-Marc Lasgouttes wrote: > > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > > > Martin> Attached, please verify. - Martin > > > > Is that a qt-only bug? > > No. > > Attache

Re: [Patch] Fix for 2212: First change is skipped in "Merge changes..." dialog

2006-02-14 Thread Martin Vermeer
On Mon, 2006-02-13 at 23:16 +0100, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> Attached, please verify. - Martin > > Is that a qt-only bug? No. Attached what is needed to fix it for xforms also. (Same wrong logic there as in qt2. Ouch.

Re: [Patch] Fix for 2212: First change is skipped in "Merge changes..." dialog

2006-02-13 Thread Martin Vermeer
On Mon, Feb 13, 2006 at 11:16:07PM +0100, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> Attached, please verify. - Martin > > Is that a qt-only bug? I am not sure. Tested only for Qt. - Martin pgpuZar0nKqrd.pgp Description: PGP signat

Re: [Patch] Fix for 2212: First change is skipped in "Merge changes..." dialog

2006-02-13 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> Attached, please verify. - Martin Is that a qt-only bug? JMarc

[Patch] Fix for 2212: First change is skipped in "Merge changes..." dialog

2006-02-06 Thread Martin Vermeer
Attached, please verify. - Martin Index: BufferView_pimpl.C === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/BufferView_pimpl.C,v retrieving revision 1.600 diff -u -p -r1.600 BufferView_pimpl.C --- BufferView_pimpl.C 29 Nov 2005 15