On Tue, Feb 14, 2006 at 08:07:36PM +0000, John Spray wrote: > Am Dienstag, den 14.02.2006, 18:33 +0200 schrieb Martin Vermeer: > > > Executive summary: my previous patch for this is not necessary > > > > But did you test this together with my fix for 2212, i.e., including my > > changes to BufferView_pimpl.C? This changes the logic. You should _not_ > > call controller().find() in update. That's precisely the faulty logic > > that my patch removes. (You do it in onNext, which should suffice.) > > > > So I suspect your original patch was OK. Please test it together with my > > fix. > > Ah, sorry, wasn't quite understanding what was going on. I've now done > that, and can confirm that your 2212 patch + your controlchanges patch + > my patch work well together. Cool.
Hmmm, great news. I'll put the complete patch on bugzilla then. > By the way, I wouldn't have been aware of this at all if I hadn't been > reading the list quite thoroughly lately. Perhaps it would be a good > idea to have some way of flagging any changes which require work on the > frontends somehow (or just CC me). Particularly relevant since at > present any controller-interaction logic bugs in qt or xforms are likely > to be replicated in gtk. Yes, you're right -- in principle. However, this is supposed to be a rare situation: a logic mix-up in (originally, I suspect) the xforms front-end was covered up by a "fix" in the core, after which also the qt and gtk front-ends had to duplicate the buggy behaviour. A comedy of errors ;-) - Martin
pgpSoeo7AwePX.pgp
Description: PGP signature
