Re: [Patch] Enable multiple independant and persistent ErrorLists

2006-08-14 Thread Georg Baum
Abdelrazak Younes wrote: > Yes, seems to. Please commit. Done (with the change requested by Lars) Georg

Re: [Patch] Enable multiple independant and persistent ErrorLists

2006-08-14 Thread Georg Baum
Lars Gullik Bjønnes wrote: > Georg Baum <[EMAIL PROTECTED]> > writes: > > | Bar::DoSomething() > | { > | std::vector x; > | for_each(x.begin(), x.end(), std::mem_fun_ref(&Foo::Fun)); > > I guess this should have been &Bar::DoSomething? No, Foo::Fun() should have no argument. Thi

Re: [Patch] Enable multiple independant and persistent ErrorLists

2006-08-14 Thread Abdelrazak Younes
Georg Baum wrote: Abdelrazak Younes wrote: Georg Baum wrote: a) The nonconst Buffer::errorList can be shortened a lot, I was not sure that the missing entry would be automatically inserted so I went for the safest road. If this is standard compliant I guess MSVC will be OK with that. This i

Re: [Patch] Enable multiple independant and persistent ErrorLists

2006-08-14 Thread Lars Gullik Bjønnes
Georg Baum <[EMAIL PROTECTED]> writes: | Example: | | class Foo { | void Fun(Foo const &); | }; | | class Bar { | void DoSomething(); | void Fun(Foo const &); | }; | | | Bar::DoSomething() | { | std::vector x; | for_each(x.begin(), x.end(), std::mem_fun_

Re: [Patch] Enable multiple independant and persistent ErrorLists

2006-08-14 Thread Georg Baum
Abdelrazak Younes wrote: > Georg Baum wrote: >> a) The nonconst Buffer::errorList can be shortened a lot, > > I was not sure that the missing entry would be automatically inserted so > I went for the safest road. If this is standard compliant I guess MSVC > will be OK with that. This is standard

Re: [Patch] Enable multiple independant and persistent ErrorLists

2006-08-13 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > And the any-patch could help I guess... | | Could you elaborate? Not more than point to the any-patch that I have posted on the list earlier. (Just a few weeks since I elaborated last time, and managed to create a tiny flame fest) -- L

Re: [Patch] Enable multiple independant and persistent ErrorLists

2006-08-13 Thread Lars Gullik Bjønnes
Georg Baum <[EMAIL PROTECTED]> writes: | Index: src/buffer.C | === | --- src/buffer.C (Revision 14657) | +++ src/buffer.C (Arbeitskopie) | @@ -1698,9 +1868,10 @@ void Buffer::getSourceCode(ostream & os, | | ErrorList cons

Re: [Patch] Enable multiple independant and persistent ErrorLists

2006-08-13 Thread Abdelrazak Younes
Georg Baum wrote: Am Sonntag, 13. August 2006 18:18 schrieb Abdelrazak Younes: I have comitted the patch. I noticed two things while resolving merge conflicts (I did not look at the patch because I don't understand enough of the errorlist business): a) The nonconst Buffer::errorList can be

Re: [Patch] Enable multiple independant and persistent ErrorLists

2006-08-13 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Hello, | | This is the continuation of my ErrorList work. | | This patch creates a error_lists map member inside the Buffer class. | Sorry Lars, I had no choice but to use string for the map key. This is | because the

Re: [Patch] Enable multiple independant and persistent ErrorLists

2006-08-13 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Hello, | | This is the continuation of my ErrorList work. | | This patch creates a error_lists map member inside the Buffer class. | Sorry Lars, I had no choice but to use string for the map key. This is | because the only information that could be

Re: [Patch] Enable multiple independant and persistent ErrorLists

2006-08-13 Thread Abdelrazak Younes
Georg Baum wrote: Am Sonntag, 13. August 2006 18:18 schrieb Abdelrazak Younes: I have comitted the patch. I noticed two things while resolving merge conflicts (I did not look at the patch because I don't understand enough of the errorlist business): a) The nonconst Buffer::errorList can be

Re: [Patch] Enable multiple independant and persistent ErrorLists

2006-08-13 Thread Georg Baum
Am Sonntag, 13. August 2006 18:18 schrieb Abdelrazak Younes: > I have comitted the patch. I noticed two things while resolving merge conflicts (I did not look at the patch because I don't understand enough of the errorlist business): a) The nonconst Buffer::errorList can be shortened a lot, and

Re: [Patch] Enable multiple independant and persistent ErrorLists

2006-08-13 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Hello, This is the continuation of my ErrorList work. Abdelrazak> This patch creates a error_lists map member inside the Abdelrazak> Buffer class. Sorry Lars, I had no choice but to use Abdelr

Re: [Patch] Enable multiple independant and persistent ErrorLists

2006-08-12 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Hello, This is the continuation of my ErrorList work. Abdelrazak> This patch creates a error_lists map member inside the Abdelrazak> Buffer class. Sorry Lars, I had no choice but to use Abdelrazak> string for the map

[Patch] Enable multiple independant and persistent ErrorLists

2006-08-12 Thread Abdelrazak Younes
Hello, This is the continuation of my ErrorList work. This patch creates a error_lists map member inside the Buffer class. Sorry Lars, I had no choice but to use string for the map key. This is because the only information that could be passed to the controller is a string. With this new archit