Georg Baum wrote:
Am Sonntag, 13. August 2006 18:18 schrieb Abdelrazak Younes:

I have comitted the patch.

I noticed two things while resolving merge conflicts (I did not look at the patch because I don't understand enough of the errorlist business):

a) The nonconst Buffer::errorList can be shortened a lot,

I was not sure that the missing entry would be automatically inserted so I went for the safest road. If this is standard compliant I guess MSVC will be OK with that.

and the empty error list can be made static and can go to the .C file (better because it does not belong to the interface)

Yes, this is because, at one point in time, I use this empty list at multiple time.

b) the for_each construct works with boost::bind, we use this at other places. mem_fun_ref calls a member function of the container element, but what we need is a member function of the LyX class.

Interesting, I shall read the boost bind doc sometimes. FYI, the standard doc says to use mem_fun_ref, if somebody knows what's wrong with the formerly commented code, I'd be interested to know.

Does this work for you, too?

Will try... thanks.

Abdel.

Reply via email to