Re: [PATCH]gtk mousewheel-scrolling support

2004-09-23 Thread Alfredo Braunstein
John Levon wrote: > Not a very nice one. Apply John's patch, darn it! I'm feeling some first > name solidarity here. LOL, it's in. Alfredo

Re: [PATCH]gtk mousewheel-scrolling support

2004-09-23 Thread John Levon
On Thu, Sep 23, 2004 at 08:11:57PM +0200, Lars Gullik Bj?nnes wrote: > | +bool GWorkArea::onScrollWheel(GdkEventScroll * event) > | +{ > | + double step; > | + Gtk::Adjustment * adjustment = vscrollbar_.get_adjustment(); > | + if (event->state & GDK_CONTROL_MASK) > | + step = adjus

Re: [PATCH]gtk mousewheel-scrolling support

2004-09-23 Thread Lars Gullik Bjønnes
John Spray <[EMAIL PROTECTED]> writes: | On Thu, 2004-09-23 at 18:33, Lars Gullik Bjønnes wrote: >> I have one more nit though... sorry about that. >> >> | +bool GWorkArea::onScrollWheel(GdkEventScroll * event) >> | +{ >> | + double step; >> >> move this down > | I have a better idea: I'll impl

Re: [PATCH]gtk mousewheel-scrolling support

2004-09-23 Thread John Spray
On Thu, 2004-09-23 at 18:33, Lars Gullik Bjønnes wrote: > I have one more nit though... sorry about that. > > | +bool GWorkArea::onScrollWheel(GdkEventScroll * event) > | +{ > | + double step; > > move this down I have a better idea: I'll implement the reason that I actually did it this way to

Re: [PATCH]gtk mousewheel-scrolling support

2004-09-23 Thread Lars Gullik Bjønnes
John Spray <[EMAIL PROTECTED]> writes: | On Thu, 2004-09-23 at 17:37, Lars Gullik Bjønnes wrote: >> You should probably read the >> Development/lyx-devel/development/Code_rules/Rules document. > | In my haste I only skimmed that before: I've read it properly now. | Thanks for your advice Lars & A

Re: [PATCH]gtk mousewheel-scrolling support

2004-09-23 Thread John Spray
On Thu, 2004-09-23 at 17:37, Lars Gullik Bjønnes wrote: > You should probably read the > Development/lyx-devel/development/Code_rules/Rules document. In my haste I only skimmed that before: I've read it properly now. Thanks for your advice Lars & Alfredo. Revised patch attached (now including ch

Re: [PATCH]gtk mousewheel-scrolling support

2004-09-23 Thread Lars Gullik Bjønnes
John Spray <[EMAIL PROTECTED]> writes: | Hi, > | Sending this to the list, because I'm not sure where is best to send | it. Would it be better to submit stuff like this into the bugzilla? Only if there is already a case in bugzilla. If not this is the better place. | Anyway, this handles the g

Re: [PATCH]gtk mousewheel-scrolling support

2004-09-23 Thread Alfredo Braunstein
John Spray wrote: > Hi, Hi! > Sending this to the list, because I'm not sure where is best to send > it. Would it be better to submit stuff like this into the bugzilla? This is the correct place for patches. > Anyway, this handles the gtk scroll event to catch scrollwheels, and > scrolls th

[PATCH]gtk mousewheel-scrolling support

2004-09-23 Thread John Spray
Hi, Sending this to the list, because I'm not sure where is best to send it. Would it be better to submit stuff like this into the bugzilla? Anyway, this handles the gtk scroll event to catch scrollwheels, and scrolls the document accordingly. John Index: GWorkArea.C ===