John Spray <[EMAIL PROTECTED]> writes:

| On Thu, 2004-09-23 at 18:33, Lars Gullik Bjønnes wrote:
>> I have one more nit though... sorry about that.
>> 
>> | +bool GWorkArea::onScrollWheel(GdkEventScroll * event)
>> | +{
>> | +  double step;
>> 
>> move this down
>
| I have a better idea: I'll implement the reason that I actually did it
| this way to begin with: scroll a step normally, but a whole page if
| control is down.  The GNOME HIG hates me for doing this (they want that
| bound to zoom in/out), but epiphany (the gnome browser) does it, and
| zooming doesn't mean anything in lyx anyhow.

No real objections now.

| +bool GWorkArea::onScrollWheel(GdkEventScroll * event)
| +{
| +     double step;
| +     Gtk::Adjustment * adjustment = vscrollbar_.get_adjustment();
| +     if (event->state & GDK_CONTROL_MASK)
| +             step = adjustment->get_page_increment();
| +     else
| +             step = adjustment->get_step_increment();

Note that 

     double step = (event->state & GDK_CONTROL_MASK ?
                 adjustment->get_page_increment() :
                 adjustment->get_step_increment());

is still an option.

-- 
        Lgb

Reply via email to