Re: [PATCH] xforms small changes

2001-03-05 Thread Angus Leeming
On Monday 05 March 2001 10:25, Lars Gullik Bjønnes wrote: > John Levon <[EMAIL PROTECTED]> writes: > > | This should help the iconify situation in xforms. > | It also fixes a qt2 compile problem, changes Splash, > | and removes the DEFAULT_LANGUAGE thing in docdlg.C > > Have this been comitted?

Re: [PATCH] xforms small changes

2001-03-05 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | This should help the iconify situation in xforms. | It also fixes a qt2 compile problem, changes Splash, | and removes the DEFAULT_LANGUAGE thing in docdlg.C Have this been comitted? Lgb

Re: [PATCH] xforms small changes

2001-02-24 Thread John Levon
On Sat, 24 Feb 2001, Allan Rae wrote: > as a free standing (not FormBase dependent) you can probably avoid the > signals or at least setup hideSplash to call a Dialogs::destroySplash() > which could then remove the splash screen entirely. makes sense. > > I can't remember how splash was handle

Re: [PATCH] xforms small changes

2001-02-23 Thread Allan Rae
On Fri, 23 Feb 2001, John Levon wrote: > On Fri, 23 Feb 2001, Angus Leeming wrote: > > > Actually, John, I'd redo FormSplash as a stand alone class, not derived from > > FormBase at all. You redefine or don't use pretty well all the virtual > > methods(). It's all a bit confusing; imagine what it

Re: [PATCH] xforms small changes

2001-02-23 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | You're trying to delete the same object twice. | | void FormSplash::build() | { | dialog_ = build_splash(); | } | | | FD_form_splash * FormSplash::build_splash() | { | FD_form_splash *fdui = new FD_form_splash; | fdui->form->u_vdata = this;

Re: [PATCH] xforms small changes

2001-02-23 Thread John Levon
On Fri, 23 Feb 2001, Angus Leeming wrote: > You're trying to delete the same object twice. > > Capisco? > A *d'oh* sorry, sorry, slow on the take today john -- "Anyone who says you can have a lot of widely dispersed people hack away on a complicated piece of code and avoid total anarchy ha

Re: [PATCH] xforms small changes

2001-02-23 Thread Angus Leeming
On Friday 23 February 2001 15:55, John Levon wrote: > On Fri, 23 Feb 2001, Angus Leeming wrote: > > > > What a weird way to ask a question ! > > > > My apologies. > > no problem, I would smiley but I know what day it is. > > > > Doesn't the "pre" delete the FormSplash object itself rather than

Re: [PATCH] xforms small changes

2001-02-23 Thread John Levon
On Fri, 23 Feb 2001, Angus Leeming wrote: > Actually, John, I'd redo FormSplash as a stand alone class, not derived from > FormBase at all. You redefine or don't use pretty well all the virtual > methods(). It's all a bit confusing; imagine what it'll be like in 6 month's > time! > > Angus M

Re: [PATCH] xforms small changes

2001-02-23 Thread Angus Leeming
On Friday 23 February 2001 15:53, John Levon wrote: > On Fri, 23 Feb 2001, Angus Leeming wrote: > > > Application form being processed by the Lunatic Asylum as we speak. > > ha ! > > > Anyway, futher comment to FormSplash. You derive it from FormBaseBI which > > already has a Connection h_. >

Re: [PATCH] xforms small changes

2001-02-23 Thread John Levon
On Fri, 23 Feb 2001, Angus Leeming wrote: > > What a weird way to ask a question ! > > My apologies. no problem, I would smiley but I know what day it is. > > Doesn't the "pre" delete the FormSplash object itself rather than the > dialog_. > > It's the equivalent of "delete this" if the Close

Re: [PATCH] xforms small changes

2001-02-23 Thread John Levon
On Fri, 23 Feb 2001, Angus Leeming wrote: > Application form being processed by the Lunatic Asylum as we speak. ha ! > Anyway, futher comment to FormSplash. You derive it from FormBaseBI which > already has a Connection h_. > > void FormBaseBI::connect() > { > h_ = d_->hideAll.connect(

Re: [PATCH] xforms small changes

2001-02-23 Thread Angus Leeming
On Friday 23 February 2001 15:39, John Levon wrote: > On Fri, 23 Feb 2001, Angus Leeming wrote: > > > void FormSplash::CloseCB(FL_OBJECT * ob) > > { > > FormSplash * pre = static_cast(ob->form->u_vdata); > > pre->hide(); > > delete pre->dialog_; > > pre->dialog_ = 0; > > + // wh

Re: [PATCH] xforms small changes

2001-02-23 Thread Angus Leeming
On Friday 23 February 2001 15:37, John Levon wrote: > On Fri, 23 Feb 2001, Angus Leeming wrote: > > > Well currently I consider you to be a b@$@!?d because of all those ^M > > carriage returns > > pre->dialog_ = 0; > > + // why this? > > delete pre; > > } > > > > Unless I'm going mad

Re: [PATCH] xforms small changes

2001-02-23 Thread John Levon
On Fri, 23 Feb 2001, Angus Leeming wrote: > void FormSplash::CloseCB(FL_OBJECT * ob) > { > FormSplash * pre = static_cast(ob->form->u_vdata); > pre->hide(); > delete pre->dialog_; > pre->dialog_ = 0; > + // why this? > delete pre; > } > > This is just a pointer

Re: [PATCH] xforms small changes

2001-02-23 Thread John Levon
On Fri, 23 Feb 2001, Angus Leeming wrote: > Well currently I consider you to be a b@$@!?d because of all those ^M > carriage returns > pre->dialog_ = 0; > + // why this? > delete pre; > } > Unless I'm going mad, my patch doesn't have either of these features. I'm really confuse

Re: [PATCH] xforms small changes

2001-02-23 Thread Angus Leeming
On Friday 23 February 2001 15:22, John Levon wrote: > On Fri, 23 Feb 2001, Angus Leeming wrote: > > > On Friday 23 February 2001 15:07, John Levon wrote: > > > > > > > > > This should help the iconify situation in xforms. > > > It also fixes a qt2 compile problem, changes Splash, > > > and remo

Re: [PATCH] xforms small changes

2001-02-23 Thread John Levon
On Fri, 23 Feb 2001, Angus Leeming wrote: > On Friday 23 February 2001 15:07, John Levon wrote: > > > > > > This should help the iconify situation in xforms. > > It also fixes a qt2 compile problem, changes Splash, > > and removes the DEFAULT_LANGUAGE thing in docdlg.C > > > > john > > The Fo

Re: [PATCH] xforms small changes

2001-02-23 Thread Angus Leeming
On Friday 23 February 2001 15:07, John Levon wrote: > > > This should help the iconify situation in xforms. > It also fixes a qt2 compile problem, changes Splash, > and removes the DEFAULT_LANGUAGE thing in docdlg.C > > john The FormSplash patch has gone both into this file and into the FileDi

[PATCH] xforms small changes

2001-02-23 Thread John Levon
This should help the iconify situation in xforms. It also fixes a qt2 compile problem, changes Splash, and removes the DEFAULT_LANGUAGE thing in docdlg.C john -- On Year 2000 compliance : "Unfortunately, it is not possible to gather similar assurances on the compliance of viruses." -