On Friday 23 February 2001 15:22, John Levon wrote:
> On Fri, 23 Feb 2001, Angus Leeming wrote:
>
> > On Friday 23 February 2001 15:07, John Levon wrote:
> >
> > > >
> > > This should help the iconify situation in xforms.
> > > It also fixes a qt2 compile problem, changes Splash,
> > > and removes the DEFAULT_LANGUAGE thing in docdlg.C
> > >
> > > john
> >
> > The FormSplash patch has gone both into this file and into the FileDialog
one.
>
> Ah, crap, I knew I'd screw up somewhere
>
> > Neat!
> >
> > Alternatively, why not delete FormSplash entirely once it's expired. That
> > would be the best possible solution I think. Ie add a destroySplash()
method
> > to Dialogs.
>
> That was my first thought, but then I considered maybe it's quite an ugly
solution
> to save about 20 bytes. I know Splash *is* a special case though.
>
> I'd be quite happy with such a solution.
Well currently I consider you to be a b@$@!?d because of all those ^M
carriage returns that have cause patch to reject most changes. (No worries;
don't require an apology!!!) Anyway, I've patched it by hand. One query:
void FormSplash::CloseCB(FL_OBJECT * ob)
{
FormSplash * pre = static_cast<FormSplash*>(ob->form->u_vdata);
pre->hide();
delete pre->dialog_;
pre->dialog_ = 0;
+ // why this?
delete pre;
}
This is just a pointer to the actual instantiation which is stored as
dialog_. Whaen dialog_ is deleted, all is Ok.
FD_form_splash * FormSplash::build_splash()
{
FL_OBJECT *obj;
FD_form_splash *fdui = new FD_form_splash;
fdui->form->u_vdata = this;
return fdui;
}
>
> thanks
> john
>
> --
> "Anyone who says you can have a lot of widely dispersed people hack away on
> a complicated piece of code and avoid total anarchy has never managed a
> software project."
> - Andy Tanenbaum
