Re: [PATCH] session/toolbars

2006-11-01 Thread Bo Peng
what dead horse? did it die in the 5 minutes from the patch was posted till I posted my reply? You should look for [Updated PATCH] or [Updated Updated PATCH] 1 hours after this. :-) Bo

Re: [PATCH] session/toolbars

2006-11-01 Thread Lars Gullik Bjønnes
"Bo Peng" <[EMAIL PROTECTED]> writes: | > This should not be static. (anon namespace is enough) | > Also indentation is wrong. | | Lars, you are shooting a dead horse. An updated patch is available. | (And a further updated patch will be available soon.) what dead horse? did it die in the 5 minu

Re: [PATCH] session/toolbars

2006-11-01 Thread Bo Peng
This should not be static. (anon namespace is enough) Also indentation is wrong. Lars, you are shooting a dead horse. An updated patch is available. (And a further updated patch will be available soon.) Bo

Re: [PATCH] session/toolbars

2006-11-01 Thread Lars Gullik Bjønnes
Peter Kümmel <[EMAIL PROTECTED]> writes: | Index: frontends/LyXView.h | === | --- frontends/LyXView.h (revision 15652) | +++ frontends/LyXView.h (working copy) | @@ -136,6 +136,7 @@ | | /// update the toolbar |

Re: [PATCH] session/toolbars

2006-11-01 Thread Bo Peng
Abdel, A new patch has been posted. To answer your questions: Well, I don't want to minimize your work Bo but for the toolbar positioning, maybe we could use Qt own session management and call that from your own session class? No, we still have the GUII policy so session does not know what q

Re: [PATCH] session/toolbars

2006-11-01 Thread Peter Kümmel
And here the updated patch. Position and visibility is stored, and when a toolbar is not visible at start up it is context sensitive. When you move a context visible toolbar the position is also rememberd even when the toolbar is hidden when exiting. Peter Index: session.C ==

Re: [PATCH] session/toolbars

2006-11-01 Thread Peter Kümmel
Bo Peng wrote: > Dear all, > > The attached patch save/restore toolbar information (right now > on/off). The patch almost works, but all toolbars are displayed even > when session disables QToolbar::show() (see patch). > > Peter and Abdel: please comment. I've added the Qt functions and changed

Re: [PATCH] session/toolbars

2006-11-01 Thread Peter Kümmel
Abdelrazak Younes wrote: > Bo Peng wrote: >> The show function now accepts a full structure that contains various >> toolbar information. How to make use of them is supposed to be >> frontend-specific. > > Well, I don't want to minimize your work Bo but for the toolbar > positioning, maybe we coul

Re: [PATCH] session/toolbars

2006-11-01 Thread Abdelrazak Younes
Bo Peng wrote: Dear all, The attached patch save/restore toolbar information (right now on/off). The patch almost works, but all toolbars are displayed even when session disables QToolbar::show() (see patch). Peter and Abdel: please comment. +ToolbarSection::ToolbarInfo & status = LyX::re

Re: [PATCH] session/toolbars

2006-11-01 Thread Peter Kümmel
Great! Bo, this was really fast. Bo Peng wrote: > Dear all, > > The attached patch save/restore toolbar information (right now > on/off). The patch almost works, but all toolbars are displayed even > when session disables QToolbar::show() (see patch). > > Peter and Abdel: please comment. > > >

[PATCH] session/toolbars

2006-10-31 Thread Bo Peng
Dear all, The attached patch save/restore toolbar information (right now on/off). The patch almost works, but all toolbars are displayed even when session disables QToolbar::show() (see patch). Peter and Abdel: please comment. + ToolbarSection::ToolbarInfo & status = LyX::ref().session()