Abdel, A new patch has been posted. To answer your questions:
Well, I don't want to minimize your work Bo but for the toolbar positioning, maybe we could use Qt own session management and call that from your own session class?
No, we still have the GUII policy so session does not know what qt is.
Make that an enum:
Good idea. Done by Peter.
> + /// potentially, icons > + }; I'd say not for 1.5.
We need to toolbar dialog to do that. It will be a good way to hide users completely from hand editing the ui files. Of course we can save this for lyx 1.6+.
Ordering would be nice but strictly necessary for now.
I guess so, and order is difficult to implement.
By the way, instead of using the global session object maybe it would be better to make the session object retrieve the version itself and save them as desired. I mean inside Session::save(LyXView & lv) ToolbarInfo const & ti = lv.toolbars().info(); string lv_id = convert<string>(lv.id()); // Where to save this id? session.sessionInfo().save("ToolbarLocation", convert<string>(ti.location()));
I do not quite get it. As of lv.id(), I am not sure if I want to save geometry for each window either. It is kind of scary to have ten lyx windows pop up when lyx starts. I would prefer loading all documents in one window, and let users open others. Bo