Re: [PATCH] qt branches fix

2003-10-26 Thread Lars Gullik Bjønnes
Alfredo Braunstein <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: > >> | I believe it is intended, because the state collapsed/uncollapsed gets >> | saved. >> >> there is a bug on bugzilla about this. And the document is not >> logically changing so this "changed" should imo not happen

Re: [PATCH] qt branches fix

2003-10-26 Thread Alfredo Braunstein
Lars Gullik Bjønnes wrote: > | I believe it is intended, because the state collapsed/uncollapsed gets > | saved. > > there is a bug on bugzilla about this. And the document is not > logically changing so this "changed" should imo not happen. > Mmm... ok. Why don't you apply John's patch on bugz

Re: [PATCH] qt branches fix

2003-10-26 Thread Lars Gullik Bjønnes
[EMAIL PROTECTED] (Juergen Spitzmueller) writes: | Alfredo Braunstein wrote: >> I believe it is intended, because the state collapsed/uncollapsed gets >> saved. > | I see. Yes, that makes sense. No... it does not... -- Lgb

Re: [PATCH] qt branches fix

2003-10-26 Thread Lars Gullik Bjønnes
Alfredo Braunstein <[EMAIL PROTECTED]> writes: | Juergen Spitzmueller wrote: > >> Juergen Spitzmueller wrote: >>> BTW do you have any idea why (un)collapsing branches sets the document's >>> state to "changed"? >> >> Actually this happens with any collapsable inset (ERT, footnote, note >> etc.).

Re: [PATCH] qt branches fix

2003-10-25 Thread Juergen Spitzmueller
Martin Vermeer wrote: > If it works (also in the borderline situations such as defining a new > branch and not rightaway a color, as well as the save/load cycle) then > very much so. I am again behind a dial-up here for the weekend. Unfortunately it does not. LyX (xforms) crashes whenever I want t

Re: [PATCH] qt branches fix

2003-10-25 Thread Angus Leeming
Martin Vermeer wrote: > On Sat, Oct 25, 2003 at 04:38:48PM +0200, Juergen Spitzmueller spake > thusly: >> >> Juergen Spitzmueller wrote: >> > Martin, I have introduced a setColor() function in >> > ControlDocument, similar to the one in ControlPrefs. I think you >> > could use that also in the xf

Re: [PATCH] qt branches fix

2003-10-25 Thread Martin Vermeer
On Sat, Oct 25, 2003 at 04:38:48PM +0200, Juergen Spitzmueller spake thusly: > > Juergen Spitzmueller wrote: > > Martin, I have introduced a setColor() function in ControlDocument, similar > > to the one in ControlPrefs. I think you could use that also in the xforms > > frontend, instead of the co

Re: [PATCH] qt branches fix

2003-10-25 Thread Juergen Spitzmueller
Juergen Spitzmueller wrote: > Martin, I have introduced a setColor() function in ControlDocument, similar > to the one in ControlPrefs. I think you could use that also in the xforms > frontend, instead of the colorhandler thing you have now. The attached patch lets xforms use the same method as qt

Re: [PATCH] qt branches fix

2003-10-25 Thread Juergen Spitzmueller
Juergen Spitzmueller wrote: > branchlist().getColor() can return string() (but it shouldn't as I read the > code). What I want is that we fall back to the background color whenever > the branch has no sensible color or color "none". Doesn't an empty string > mean "no color"? Anyway, the branches ba

Re: [PATCH] qt branches fix

2003-10-25 Thread Juergen Spitzmueller
Angus Leeming wrote: > Index: src/frontends/qt2/QDocument.C > > > +     string x11hexname = params.branchlist().getColor(current_branch); > > +     // check that we have a valid color! > > +     if (x11hexname[0] != '#') > > +             x11hexname = lcolor.getX11Name(LColor::background); > > Is t

Re: [PATCH] qt branches fix

2003-10-25 Thread Angus Leeming
Juergen Spitzmueller wrote: Index: src/frontends/qt2/QDocument.C > + string x11hexname = params.branchlist().getColor(current_branch); > + // check that we have a valid color! > + if (x11hexname[0] != '#') > + x11hexname = lcolor.getX11Name(LColor::background); Is this saf

Re: [PATCH] qt branches fix

2003-10-25 Thread Juergen Spitzmueller
Juergen Spitzmueller wrote: > Attached is a fix for the branches color issues in qt (1. branches color > was not immediately updated, buffer reload was necessary; 2. new branches > had black background). Everything works as expected now. *Sigh* Please try this one. I don't think a LyXName -> LColo

Re: [PATCH] qt branches fix

2003-10-25 Thread Juergen Spitzmueller
Alfredo Braunstein wrote: > I believe it is intended, because the state collapsed/uncollapsed gets > saved. I see. Yes, that makes sense. Thanks, Jürgen.

Re: [PATCH] qt branches fix

2003-10-25 Thread Alfredo Braunstein
Juergen Spitzmueller wrote: > Juergen Spitzmueller wrote: >> BTW do you have any idea why (un)collapsing branches sets the document's >> state to "changed"? > > Actually this happens with any collapsable inset (ERT, footnote, note > etc.). I believe it is intended, because the state collapsed/un

Re: [PATCH] qt branches fix

2003-10-25 Thread Juergen Spitzmueller
Juergen Spitzmueller wrote: > BTW do you have any idea why (un)collapsing branches sets the document's > state to "changed"? Actually this happens with any collapsable inset (ERT, footnote, note etc.). Jürgen.

[PATCH] qt branches fix

2003-10-25 Thread Juergen Spitzmueller
Attached is a fix for the branches color issues in qt (1. branches color was not immediately updated, buffer reload was necessary; 2. new branches had black background). Everything works as expected now. Martin, I have introduced a setColor() function in ControlDocument, similar to the one in C