Juergen Spitzmueller wrote:
Index: src/frontends/qt2/QDocument.C
> + string x11hexname = params.branchlist().getColor(current_branch);
> + // check that we have a valid color!
> + if (x11hexname[0] != '#')
> + x11hexname = lcolor.getX11Name(LColor::background);
Is this safe? Can branchlist().getColor() return string()? If so, you
should have
if (x11hexname.empty() || x11hexname[0] != '#')
> + lcolor.setColor(current_branch, x11hexname);
This doesn't belong in the frontends. This should be moved into the
controller along, into the function called in the very next line in
fact.
+ controller().setBranchColor(current_branch, x11hexname);
Eventually we'll move the lcolor.setColor call back into the core,
where it belongs...
Regards,
--
Angus
