Re: [PATCH] move the X11 selection handling out of BufferView

2006-09-18 Thread Abdelrazak Younes
Georg Baum wrote: Abdelrazak Younes wrote: I did not dismiss your work entirely, please reread my older messages. I only pointed out that it might not be the cleanup you think it is, and I said more than once that I don't know the full picture either. Otherwise I would have complained about a sp

Re: [PATCH] move the X11 selection handling out of BufferView

2006-09-18 Thread Georg Baum
Abdelrazak Younes wrote: > Georg Baum wrote: >> Partly. I do know a bit about it, but not enough to completely understand >> the current selection code, in particular not why there is this static >> xsel_cache_ variable. This is of course not your doing, but a real >> cleanup would only be possibl

Re: [PATCH] move the X11 selection handling out of BufferView

2006-09-18 Thread Abdelrazak Younes
Georg Baum wrote: Abdelrazak Younes wrote: Georg Baum wrote: Am Samstag, 16. September 2006 18:47 schrieb Abdelrazak Younes: I don't need to know. I am just moving code around and this should just work. I am quite confident actually that it _will_ just work. OK, suppose it works. Then there

Re: [PATCH] move the X11 selection handling out of BufferView

2006-09-18 Thread Georg Baum
Abdelrazak Younes wrote: > Georg Baum wrote: >> Am Samstag, 16. September 2006 18:47 schrieb Abdelrazak Younes: >> >>> I don't need to know. I am just moving code around and this should just >>> work. I am quite confident actually that it _will_ just work. >> >> OK, suppose it works. Then there

Re: [PATCH] move the X11 selection handling out of BufferView

2006-09-18 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Georg, if you have a comment or an abjection Abjection, really? ;) Oups :-) This is just a typo Georg... Abdel.

Re: [PATCH] move the X11 selection handling out of BufferView

2006-09-18 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Georg, if you have a comment or an abjection Abjection, really? ;) JMarc

Re: [PATCH] move the X11 selection handling out of BufferView

2006-09-17 Thread Abdelrazak Younes
Georg Baum wrote: selection, so a sensible cleanup IMO would be to rename selectionRequested to requestSelection and selectionLost to clearSelection. I've done that and verified that it will compile under X11. Will commit soon. Abdel. Index: BufferView.C =

Re: [PATCH] move the X11 selection handling out of BufferView

2006-09-17 Thread Abdelrazak Younes
Andre Poenitz wrote: On Sat, Sep 16, 2006 at 07:19:16PM +0200, Georg Baum wrote: Am Samstag, 16. September 2006 18:47 schrieb Abdelrazak Younes: I don't need to know. I am just moving code around and this should just work. I am quite confident actually that it _will_ just work. OK, suppose it

Re: [PATCH] move the X11 selection handling out of BufferView

2006-09-17 Thread Abdelrazak Younes
Georg Baum wrote: Am Samstag, 16. September 2006 18:47 schrieb Abdelrazak Younes: I don't need to know. I am just moving code around and this should just work. I am quite confident actually that it _will_ just work. OK, suppose it works. Then there is still the problem that this is supposed

Re: [PATCH] move the X11 selection handling out of BufferView

2006-09-16 Thread Bo Peng
I suhppose some thing can simplyh be handled entirelyu in the individual frontends without any(/much) kernel interaction at all. This I agree. Bo

Re: [PATCH] move the X11 selection handling out of BufferView

2006-09-16 Thread Andre Poenitz
On Sat, Sep 16, 2006 at 07:19:16PM +0200, Georg Baum wrote: > Am Samstag, 16. September 2006 18:47 schrieb Abdelrazak > Younes: > > > I don't need to know. I am just moving code around and this > > should just work. I am quite confident actually that it > > _will_ just work. > > OK, suppose it wo

Re: [PATCH] move the X11 selection handling out of BufferView

2006-09-16 Thread Georg Baum
Am Samstag, 16. September 2006 18:47 schrieb Abdelrazak Younes: > I don't need to know. I am just moving code around and this should just > work. I am quite confident actually that it _will_ just work. OK, suppose it works. Then there is still the problem that this is supposed to be a cleanup,

Re: [PATCH] move the X11 selection handling out of BufferView

2006-09-16 Thread Abdelrazak Younes
Georg Baum wrote: Am Samstag, 16. September 2006 16:43 schrieb Abdelrazak Younes: Yes, sorry... Attached a patch that should work. Not tested yet. And you can't test it on windows. I am afraid that you don't know enough about X selection in order to do this blindly. For example, do you know

Re: [PATCH] move the X11 selection handling out of BufferView

2006-09-16 Thread Georg Baum
Am Samstag, 16. September 2006 16:43 schrieb Abdelrazak Younes: > Yes, sorry... Attached a patch that should work. Not tested yet. And you can't test it on windows. I am afraid that you don't know enough about X selection in order to do this blindly. For example, do you know why there is a xsel

Re: [PATCH] move the X11 selection handling out of BufferView

2006-09-16 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | As the title says. | | This patch supports all frontends and is straight forward. I intent to | put this general code in some code common to all frontends in the | future. | | Abdel. It looks as if you forgot to remo

Re: [PATCH] move the X11 selection handling out of BufferView

2006-09-16 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | As the title says. | | This patch supports all frontends and is straight forward. I intent to | put this general code in some code common to all frontends in the | future. | | Abdel. | | Log: | * BufferView: | - BufferView::selectionRequested()

[PATCH] move the X11 selection handling out of BufferView

2006-09-16 Thread Abdelrazak Younes
As the title says. This patch supports all frontends and is straight forward. I intent to put this general code in some code common to all frontends in the future. Abdel. Log: * BufferView: - BufferView::selectionRequested() changed to docstring const & getStringSelection(), the X11 selecti