Re: [PATCH] fix bug in insetquote

2002-10-15 Thread Jean-Marc Lasgouttes
> "John" == John Levon <[EMAIL PROTECTED]> writes: John> On Thu, Sep 26, 2002 at 09:14:25AM +0200, Juergen Spitzmueller John> wrote: >> Juergen Spitzmueller wrote: > Not good enough. I have left out the >> «guillemots» >> >> Hmpff. The guillemots need the brackets when they are used as >> cl

Re: [PATCH] fix bug in insetquote

2002-10-14 Thread John Levon
On Thu, Sep 26, 2002 at 09:14:25AM +0200, Juergen Spitzmueller wrote: > Juergen Spitzmueller wrote: > > Not good enough. I have left out the «guillemots» > > Hmpff. > The guillemots need the brackets when they are used as closing quotes > (otherwise the space to the next word is swapped). I hav

Re: [PATCH] fix bug in insetquote

2002-10-11 Thread Juergen Spitzmueller
Lars Gullik Bjønnes wrote: > Is the patch reversed? The text above would imply that? No, I was a little confused when sending the second version of the quote patch. This one (quotmarks3.diff) corrects some mistakes in the quotmarks2.diff (guillemots handling) and it is sane to apply IMO (and we

Re: [PATCH] fix bug in insetquote

2002-10-11 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: > | Juergen> Juergen Spitzmueller wrote: >>> Not good enough. I have left out the «guillemots» > | Juergen> Hmpff. The guillemots need the brackets when they are used as | Juergen

Re: [PATCH] fix bug in insetquote

2002-10-11 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Juergen Spitzmueller wrote: >> Not good enough. I have left out the «guillemots» Juergen> Hmpff. The guillemots need the brackets when they are used as Juergen> closing quotes (otherwise the space to the next word is Ju

Re: [PATCH] fix bug in insetquote

2002-09-25 Thread Juergen Spitzmueller
Juergen Spitzmueller wrote: > Not good enough. I have left out the «guillemots» Hmpff. The guillemots need the brackets when they are used as closing quotes (otherwise the space to the next word is swapped). I have readded them again, so this patch is sane. Sorry, Jürgen. Index: src/insets/Ch

Re: [PATCH] fix bug in insetquote

2002-09-25 Thread Juergen Spitzmueller
Andre Poenitz wrote: > Looks good. Not good enough. I have left out the «guillemots» because I couldn't find any kerning. I think -- at least for consistency reasons -- the {} should go there too. Corrected patch attached. Jürgen Index: src/insets/ChangeLog ===

Re: [PATCH] fix bug in insetquote

2002-09-25 Thread Andre Poenitz
On Wed, Sep 25, 2002 at 02:50:06PM +0200, Juergen Spitzmueller wrote: > Have a look at the attached example file, and you'll see that this is indeed > visible and leads to ugly typography. > The attached patch changes insetquote.C accordingly. Looks good. Andre' -- Those who desire to give up

[PATCH] fix bug in insetquote

2002-09-25 Thread Juergen Spitzmueller
There is a cosmetic bug in the quote inset which is visible with single quotation marks. E.g., for german single quotation marks, LyX uses \quotesinglbase{}foo{}` but the {} suppresses the kerning in the following character. The correct usage would be \quotesinglbase foo{}` Have a look at th