Re: [PATCH] context menus for conglomerate insets

2008-04-15 Thread Abdelrazak Younes
Abdelrazak Younes wrote: BufferView::mouseSetCursor() is used with button1 and button3 so we need an additional boolean parameter for this. For button1, we definitly don't want to set the cursor inside a non editable inset. For button3 on the other hand we could push back the cursor slice temp

Re: [PATCH] context menus for conglomerate insets

2008-04-15 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdel, I think the problem is that, when right-clicking on an inset button, I think the cursor should be set to include the isnet as a slice, even when the inset is closed or is not highly editable. Won't this

Re: [PATCH] context menus for conglomerate insets

2008-04-15 Thread Jean-Marc Lasgouttes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> Abdel, I think the problem is that, when right-clicking on an inset >> button, I think the cursor should be set to include the isnet as a >> slice, even when the inset is closed or is not highly editable. > > Won't this lead to crash or assertion in

Re: [PATCH] context menus for conglomerate insets

2008-04-15 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: Pavel Sanda <[EMAIL PROTECTED]> writes: The 'show label' entry of conglomerate-style insets (charstyles) is not working. aha. well just the few others i remember now: all insets: dissolve is disabled when clicking on the top label, checkboxes are not vi

Re: [PATCH] context menus for conglomerate insets

2008-04-15 Thread Jean-Marc Lasgouttes
Pavel Sanda <[EMAIL PROTECTED]> writes: >> The 'show label' entry of conglomerate-style insets (charstyles) is >> not working. > > aha. well just the few others i remember now: > all insets: dissolve is disabled when clicking on the top label, > checkboxes are not visible (eg note ins

Re: [PATCH] context menus for conglomerate insets

2008-04-10 Thread Pavel Sanda
> >> The following patch fixes the context menus for conglomerate-like > >> insets. > > > > can you be more specific what exactly are you trying to fix? > > currently i know about more bugs about the context menu of > > insets toggling. > > The 'show label' entry of conglomerate-style insets (char

Re: [PATCH] context menus for conglomerate insets

2008-04-10 Thread Jean-Marc Lasgouttes
Pavel Sanda <[EMAIL PROTECTED]> writes: >> The following patch fixes the context menus for conglomerate-like >> insets. > > can you be more specific what exactly are you trying to fix? > currently i know about more bugs about the context menu of > insets toggling. The 'show label' entry of conglo

Re: [PATCH] context menus for conglomerate insets

2008-04-09 Thread Pavel Sanda
> The following patch fixes the context menus for conglomerate-like > insets. can you be more specific what exactly are you trying to fix? currently i know about more bugs about the context menu of insets toggling. > I am not sure what the current > one exactly is. i tried to document the curren

[PATCH] context menus for conglomerate insets

2008-04-09 Thread Jean-Marc Lasgouttes
The following patch fixes the context menus for conglomerate-like insets. The problem was in the way next-inset-toggle and inset-toggle work. Here is the situation as it used to be. I am not sure what the current one exactly is. * next-inset-toggle finds a suitable inset, either next to cursor