> The following patch fixes the context menus for conglomerate-like
> insets.

can you be more specific what exactly are you trying to fix?
currently i know about more bugs about the context menu of
insets toggling.

> I am not sure what the current
> one exactly is.

i tried to document the current situation in lfun doxies.

> Normally, I believe that all calls to next-inset-xxx should be
> inset-xxx instead in stdcontext.inc. 

you won't be able to call 'open' on some insets then.

>       case LFUN_INSET_TOGGLE:
> -             if ((cmd.argument() == "open" && status_ != Open)
> -                   || (cmd.argument() == "close" && status_ == Open)
> -                   || cmd.argument() == "toggle" || cmd.argument().empty())
> -                             flag.enabled(true);
> -             else
> +             if (cmd.argument() == "open")
> +                     flag.enabled(status_ != Open);
> +             else if (cmd.argument() == "close")
> +                     flag.enabled(status_ == Open);
> +             else if (cmd.argument() == "toggle" || cmd.argument().empty()) {
> +                     flag.enabled(true);
> +                     flag.setOnOff(status_ == Open);
> +             } else
>                       flag.enabled(false);
>               return true;

do i see correctly this does not change anything wrt functionality?

>       Menu "context-conglomerate"
> -             Item "Toggle Label|L" "next-inset-toggle"
> +             Item "Show Name|N" "inset-toggle"
>               Item "Dissolve Inset|D" "inset-dissolve charstyle"
>               Separator
>               OptItem "Settings...|S" "inset-settings"

btw what kind of inset is now set conglomerate ?

pavel

Reply via email to