Re: [PATCH] Thesaurus dialog

2003-01-27 Thread John Levon
On Mon, Jan 27, 2003 at 02:43:49PM +0100, Michael Schmitt wrote: > >No. Most of these aren't column headers but labels for the entire > >widget. > > > Huh? Are you sure? I double-checked these modifications. In particular, What did you "double-check" and how ? > I made sure that QT doesn't use

Re: [PATCH] Thesaurus dialog

2003-01-27 Thread Michael Schmitt
John Levon wrote: n Mon, Jan 27, 2003 at 10:59:44AM +0100, Michael Schmitt wrote: John, is this the answer to all our problems? No. Most of these aren't column headers but labels for the entire widget. Huh? Are you sure? I double-checked these modifications. In particular, I made sure

Re: [PATCH] Thesaurus dialog

2003-01-27 Thread John Levon
On Mon, Jan 27, 2003 at 10:59:44AM +0100, Michael Schmitt wrote: > John, is this the answer to all our problems? No. Most of these aren't column headers but labels for the entire widget.

Re: [PATCH] Thesaurus dialog

2003-01-27 Thread Andre Poenitz
On Mon, Jan 27, 2003 at 10:59:44AM +0100, Michael Schmitt wrote: > >What about the spell checker dialog? Should "Suggestion" have a colon > >or not? According to your rule, it should have _no_ colon but the > >dialog looks more consistent with colons. I can live with any rule as > >long as it is

Re: [PATCH] Thesaurus dialog

2003-01-27 Thread Michael Schmitt
Michael Schmitt wrote: John Levon wrote: -Thesaurus entries + Thesaurus entries: This looks wrong. Column headers in lists should not have colons afaik. Oh, no! Lars would not be very happy if he notices our discussion... What about the spell checker

Re: [PATCH] Thesaurus dialog

2003-01-26 Thread John Levon
On Sun, Jan 26, 2003 at 11:11:34PM +0100, Michael Schmitt wrote: > -&Keyword > +&Keyword: This is correct. > -Thesaurus entries > +Thesaurus entries: This looks wrong. Column headers in lists should not have

Re: [PATCH] Thesaurus dialog

2003-01-26 Thread Michael Schmitt
> > Unfortunately, in the thesaurus dialog, you have removed some of the > > dearly beloved colons which I have introduced for consistency reasons > > (they are used in all other dialogs). Attached please find another patch > > for the dialog that re-introduces them and shrinks the xforms dialog to

Re: [PATCH] Thesaurus dialog

2003-01-26 Thread Angus Leeming
Michael Schmitt wrote: > Dear Angus, > > thank you very much for the nice redesign of the spell checker dialog. > The arrangement of the buttons makes much more sense now! > > Unfortunately, in the thesaurus dialog, you have removed some of the > dearly beloved colons which I have introduced for

[PATCH] Thesaurus dialog

2003-01-26 Thread Michael Schmitt
Dear Angus, thank you very much for the nice redesign of the spell checker dialog. The arrangement of the buttons makes much more sense now! Unfortunately, in the thesaurus dialog, you have removed some of the dearly beloved colons which I have introduced for consistency reasons (they are used