Re: [PATCH] Support dark mode in workarea

2020-12-14 Thread Jürgen Spitzmüller
Am Di., 15. Dez. 2020 um 05:34 Uhr schrieb Richard Kimberly Heck < rikih...@lyx.org>: > Fixed. Not sure what I was thinking. > Thank you. Jürgen > > Riki > > > -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [PATCH] Support dark mode in workarea

2020-12-14 Thread Richard Kimberly Heck
On 12/12/20 12:08 PM, Richard Kimberly Heck wrote: On 12/12/20 4:02 AM, Jürgen Spitzmüller wrote: Am Freitag, dem 11.12.2020 um 22:49 +0100 schrieb Pavel Sanda: Closing ERT inset produces thin box with no text visible. This one's not caused by this patch. I suspect it has been introduced by 16

Re: [PATCH] Support dark mode in workarea

2020-12-13 Thread Jürgen Spitzmüller
Am Sonntag, dem 13.12.2020 um 13:38 +0100 schrieb Stephan Witt: > With the attached patch I’m seeing this: >   > frontends/qt/GuiApplication.cpp (2836): application palette change > frontends/qt/GuiView.cpp (1433): application palette change > frontends/qt/GuiView.cpp (1436): main window palette ch

Re: [PATCH] Support dark mode in workarea

2020-12-13 Thread Stephan Witt
> Am 13.12.2020 um 12:57 schrieb Jürgen Spitzmüller : > > Am Sonntag, dem 13.12.2020 um 11:01 +0100 schrieb Stephan Witt: >> I’ll do some investigation how to detect the switch from or to dark >> mode at runtime. >> I think it’s worth to afford - see the effect below. (Switch from >> dark mode

Re: [PATCH] Support dark mode in workarea

2020-12-13 Thread Jürgen Spitzmüller
Am Sonntag, dem 13.12.2020 um 11:01 +0100 schrieb Stephan Witt: > I’ll do some investigation how to detect the switch from or to dark > mode at runtime.  > I think it’s worth to afford - see the effect below. (Switch from > dark mode back to normal.) I agree. It's probably not hard if we know whic

Re: [PATCH] Support dark mode in workarea

2020-12-13 Thread Jürgen Spitzmüller
Am Samstag, dem 12.12.2020 um 15:05 +0100 schrieb Jean-Marc Lasgouttes: > Le 12/12/2020 à 11:02, Jürgen Spitzmüller a écrit : > > One issue I see is that the IconInfo inset does not use the adapted > > icons; it loads the icon files directly via graphic inset. > > > > This could be fixed by using

Re: [PATCH] Support dark mode in workarea

2020-12-12 Thread José Abílio Matos
On Friday, December 11, 2020 6:50:49 PM WET Jürgen Spitzmüller wrote: > Dear all > > The attached patch addresses #8325 and adds support for dark mode in > the workarea. I tried the committed version. The improvement is striking, in some cases the difference is between not to be able to read the

Re: [PATCH] Support dark mode in workarea

2020-12-12 Thread Richard Kimberly Heck
On 12/12/20 4:02 AM, Jürgen Spitzmüller wrote: > Am Freitag, dem 11.12.2020 um 22:49 +0100 schrieb Pavel Sanda: >> Closing ERT inset produces thin box with no text visible. > This one's not caused by this patch. I suspect it has been introduced > by 16834a32ad (Use LOCK symbol with Minimalistic dec

Re: [PATCH] Support dark mode in workarea

2020-12-12 Thread Jürgen Spitzmüller
Am Samstag, dem 12.12.2020 um 14:54 +0100 schrieb Pavel Sanda: > I can change those few cases mentioned if you don't mind. Go ahead. Note, though, that I already tried to address those, so please re-check with master before changing. Jürgen signature.asc Description: This is a digitally signed

Re: [PATCH] Support dark mode in workarea

2020-12-12 Thread Jean-Marc Lasgouttes
Le 12/12/2020 à 11:02, Jürgen Spitzmüller a écrit : One issue I see is that the IconInfo inset does not use the adapted icons; it loads the icon files directly via graphic inset. This could be fixed by using a QPixmap (or QImage) via QPainter instead. Then we can just do the same overlay we do f

Re: [PATCH] Support dark mode in workarea

2020-12-12 Thread Pavel Sanda
On Sat, Dec 12, 2020 at 09:23:23AM +0100, Jürgen Spitzmüller wrote: > Thanks. As I said, colors are just tentative now. They should be > adapted by someone who uses dark mode once this is committed. I can change those few cases mentioned if you don't mind. Pavel -- lyx-devel mailing list lyx-deve

Re: [PATCH] Support dark mode in workarea

2020-12-12 Thread Jürgen Spitzmüller
Am Freitag, dem 11.12.2020 um 22:49 +0100 schrieb Pavel Sanda: > The icons inserted via insetinfo in manual are invisible (completely > black), eg. section 13 in math manual. One issue I see is that the IconInfo inset does not use the adapted icons; it loads the icon files directly via graphic ins

Re: [PATCH] Support dark mode in workarea

2020-12-12 Thread Jürgen Spitzmüller
Am Freitag, dem 11.12.2020 um 22:49 +0100 schrieb Pavel Sanda: > Closing ERT inset produces thin box with no text visible. This one's not caused by this patch. I suspect it has been introduced by 16834a32ad (Use LOCK symbol with Minimalistic decoration, too.). Riki? Jürgen signature.asc Descr

Re: [PATCH] Support dark mode in workarea

2020-12-12 Thread Jürgen Spitzmüller
Am Freitag, dem 11.12.2020 um 22:49 +0100 schrieb Pavel Sanda: > I needed to override isDarkMode() to true to > see the dark mode at all. All my toolbar stay in light mode, not sure > how to turn them to dark mode here). You need to manually select a dark qt theme via (e.g. QT_STYLE_OVERRIDE=adwai

Re: [PATCH] Support dark mode in workarea

2020-12-12 Thread Jürgen Spitzmüller
Am Freitag, dem 11.12.2020 um 22:49 +0100 schrieb Pavel Sanda: > I am somewhat confused that that content of greyed out is (too) dark > blue in math manual, but when I create greyedout inset in completely > new file the color is (correctly) grey. The reason is that a custom color for greyedout tex

Re: [PATCH] Support dark mode in workarea

2020-12-12 Thread Jürgen Spitzmüller
Am Freitag, dem 11.12.2020 um 15:17 -0500 schrieb Richard Kimberly Heck: > I also don't use dark mode, but the approach seems right. One > question I > had, though, is whether it is better to adapt the icons on the fly > (which needs processing power) or to write some script that would > convert th

Re: [PATCH] Support dark mode in workarea

2020-12-12 Thread Jürgen Spitzmüller
Am Freitag, dem 11.12.2020 um 22:49 +0100 schrieb Pavel Sanda: > On Fri, Dec 11, 2020 at 07:50:49PM +0100, Jürgen Spitzmüller wrote: > > Thoughts? > > I gave it a try. The labels on (foot/lyx/comment/margin)notes are > hard to read > because the text is too light or not enough intense (margin) IMH

Re: [PATCH] Support dark mode in workarea

2020-12-11 Thread Pavel Sanda
On Fri, Dec 11, 2020 at 07:50:49PM +0100, Jürgen Spitzmüller wrote: > Thoughts? I gave it a try. The labels on (foot/lyx/comment/margin)notes are hard to read because the text is too light or not enough intense (margin) IMHO. I am somewhat confused that that content of greyed out is (too) dark bl

Re: [PATCH] Support dark mode in workarea

2020-12-11 Thread Richard Kimberly Heck
On 12/11/20 1:50 PM, Jürgen Spitzmüller wrote: > Dear all > > The attached patch addresses #8325 and adds support for dark mode in > the workarea. > > This adds another color to the ColorSet, x11darkhexname, and adds > colors that work well with dark background for the semantic (not the > static) c