Am Sonntag, dem 13.12.2020 um 13:38 +0100 schrieb Stephan Witt:
> With the attached patch I’m seeing this:
>  
> frontends/qt/GuiApplication.cpp (2836): application palette change
> frontends/qt/GuiView.cpp (1433): application palette change
> frontends/qt/GuiView.cpp (1436): main window palette change
> frontends/qt/GuiApplication.cpp (2836): application palette change
> frontends/qt/GuiApplication.cpp (2836): application palette change
> frontends/qt/GuiApplication.cpp (2836): application palette change
> frontends/qt/GuiApplication.cpp (2836): application palette change
> frontends/qt/GuiApplication.cpp (2836): application palette change
> frontends/qt/GuiApplication.cpp (2836): application palette change
> frontends/qt/GuiApplication.cpp (2836): application palette change
> frontends/qt/GuiApplication.cpp (2836): application palette change
> frontends/qt/GuiApplication.cpp (2836): application palette change
> frontends/qt/GuiApplication.cpp (2836): application palette change
> frontends/qt/GuiApplication.cpp (2836): application palette change
> frontends/qt/GuiApplication.cpp (2836): application palette change
> frontends/qt/GuiApplication.cpp (2836): application palette change
> 
> Getting the application palette change in GuiApplication.cpp 14 times
> is weird.
> Perhaps we have 14 Qt objects with application scope or whatever. 
> Or GuiView and GuiToolbar are dispatched separately, I don’t know.
> 
> What’s a good path to come closer to the destination? I may look for
> it later myself.

I don't know. Maybe cache the value if isDarkMode() and see whether
that changed after a signal emission.

As for the workarea, calling 
d->color_cache_.clear();
should re-trigger the colors

Toolbars looks more difficult, as there is no way to trigger a rebuild
of the toolbars AFAICS. One way might be to save lightmode and darkmode
icons, as we do for rtlIcon_ and switch that after the signal.

Jürgen

Attachment: signature.asc
Description: This is a digitally signed message part

-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Reply via email to