Re: [PATCH] Some code factorization in toolbars

2004-11-12 Thread Andre Poenitz
On Tue, Nov 09, 2004 at 04:05:28PM +0100, Jean-Marc Lasgouttes wrote: > I know, but I am ambivalent about that. I like the fact that somebody > outside of the LyX team can distribute a layout file and have a way to > deprecate layouts. Such layout files exist in the beamer class, for > example. The

Re: [PATCH] Some code factorization in toolbars

2004-11-12 Thread Andre Poenitz
On Tue, Nov 09, 2004 at 01:38:49PM +0100, Jean-Marc Lasgouttes wrote: > > "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > > Lars> Yes, I know. but ideally we should not work on the translated > Lars> name, but on some index instead. > > What makes it a bit complicated is that obso

Re: [PATCH] Some code factorization in toolbars

2004-11-12 Thread José Abílio Oliveira Matos
On Fri, Nov 12, 2004 at 03:56:20PM +0100, Jean-Marc Lasgouttes wrote: > > "José" == José Abílio Oliveira Matos <[EMAIL PROTECTED]> writes: > > José> Clearly if I implement this feature it will have a lot more > José> flexibility than that. Including conditional convertions > José> depending

Re: [PATCH] Some code factorization in toolbars

2004-11-12 Thread Jean-Marc Lasgouttes
> "José" == José Abílio Oliveira Matos <[EMAIL PROTECTED]> writes: José> Clearly if I implement this feature it will have a lot more José> flexibility than that. Including conditional convertions José> depending on the version available is too easy to do. José> Also it would allow more in

Re: [PATCH] Some code factorization in toolbars

2004-11-09 Thread José Abílio Oliveira Matos
On Tue, Nov 09, 2004 at 04:05:28PM +0100, Jean-Marc Lasgouttes wrote: > > José> Notice that we can remove the support for obsolete layouts > José> from the textclass and pass them to lyx2lyx. Even use a user > José> defined file to do this convertion. What do you think? > > I know, but I am amb

Re: [PATCH] Some code factorization in toolbars

2004-11-09 Thread Jean-Marc Lasgouttes
> "José" == José Abílio Oliveira Matos <[EMAIL PROTECTED]> writes: José> On Tue, Nov 09, 2004 at 01:38:49PM +0100, Jean-Marc Lasgouttes José> wrote: >> What makes it a bit complicated is that obsolete layouts, which do >> have an index in the list of layouts, do not appear in the combox. >> S

Re: [PATCH] Some code factorization in toolbars

2004-11-09 Thread José Abílio Oliveira Matos
On Tue, Nov 09, 2004 at 01:38:49PM +0100, Jean-Marc Lasgouttes wrote: > > What makes it a bit complicated is that obsolete layouts, which do > have an index in the list of layouts, do not appear in the combox. So > using indices means more work. Notice that we can remove the support for obsolet

Re: [PATCH] Some code factorization in toolbars

2004-11-09 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > | Lars> Yes, I know. but ideally we should not work on the translated | Lars> name, but on some index instead. > | What makes it a bit complicated is that obsolete layouts, which do

Re: [PATCH] Some code factorization in toolbars

2004-11-09 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> Yes, I know. but ideally we should not work on the translated Lars> name, but on some index instead. What makes it a bit complicated is that obsolete layouts, which do have an index in the list of layouts, do not appear in the

Re: [PATCH] Some code factorization in toolbars

2004-11-09 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > | | +void layoutSelected(LyXView & lv, string name) > | Lars> string const & name > | Oops! It seems that it pays to post the patches. > | | + // Yes, the _() is correct > | Lars> Bu

Re: [PATCH] Some code factorization in toolbars

2004-11-09 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: | +void layoutSelected(LyXView & lv, string name) Lars> string const & name Oops! It seems that it pays to post the patches. | + // Yes, the _() is correct Lars> But it shouldn't be... Should we ever work with translated names Lar

Re: [PATCH] Some code factorization in toolbars

2004-11-08 Thread Andre Poenitz
On Mon, Nov 08, 2004 at 05:54:09PM +0100, Jean-Marc Lasgouttes wrote: > > The following patch introduce the new free-standing function > layoutSelected that replaces three similar pieces of code in the > frontends. > > I'll apply shortly. I'd rather see strings passed as reference. Andre'

Re: [PATCH] Some code factorization in toolbars

2004-11-08 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | The following patch introduce the new free-standing function | layoutSelected that replaces three similar pieces of code in the | frontends. > | I'll apply shortly. > | JMarc > > | Index: src/frontends/ChangeLog | =

[PATCH] Some code factorization in toolbars

2004-11-08 Thread Jean-Marc Lasgouttes
The following patch introduce the new free-standing function layoutSelected that replaces three similar pieces of code in the frontends. I'll apply shortly. JMarc Index: src/frontends/ChangeLog === RCS file: /usr/local/lyx/cvsroot/