Re: [PATCH] Remove indirection in BufferView::Pimpl

2005-02-14 Thread Jean-Marc Lasgouttes
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: Andre> - LCursor & cur = bv_->cursor(); Andre> + LCursor & cur = cursor_; Andre> Looks like even more potential for improvements... Yes. I had to stop at some point, but there are so many things that should be cleaned up that I got very

Re: [PATCH] Remove indirection in BufferView::Pimpl

2005-02-12 Thread Andre Poenitz
On Mon, Feb 07, 2005 at 04:10:12PM +0100, Jean-Marc Lasgouttes wrote: > > "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > > Jean-Marc> OK. So here is an expanded version, where I replaced all > Jean-Marc> the easy things. > > Hmm, empty patch. Try this one instead. @@ -459

Re: [PATCH] Remove indirection in BufferView::Pimpl

2005-02-07 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> I cannot see anything at a quick glance. And I guess if it works Lars> it works. Should be pretty low-risk anyway. Yes. I committed it. JMarc

Re: [PATCH] Remove indirection in BufferView::Pimpl

2005-02-07 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: I cannot see anything at a quick glance. And I guess if it works it works. Should be pretty low-risk anyway. -- Lgb

Re: [PATCH] Remove indirection in BufferView::Pimpl

2005-02-07 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: Jean-Marc> OK. So here is an expanded version, where I replaced all Jean-Marc> the easy things. Hmm, empty patch. Try this one instead. JMarc Index: src/ChangeLog ==

Re: [PATCH] Remove indirection in BufferView::Pimpl

2005-02-07 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> I like it. We should reduce these up-calls as much as possible. OK. So here is an expanded version, where I replaced all the easy things. Lars> Would be brilliant if we came to the point where the pimpl owner Lars> did not ha

Re: [PATCH] Remove indirection in BufferView::Pimpl

2005-02-07 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | The following patch is the result of a simple s/bv_->cursor()/cursor_/ | on BufferView_pimpl.C. Indeed, BufferView::cursor() is defined as: > | LCursor & BufferView::cursor() | { | return pimpl_->cursor_; | } > > | LCursor const & BufferView

[PATCH] Remove indirection in BufferView::Pimpl

2005-02-07 Thread Jean-Marc Lasgouttes
The following patch is the result of a simple s/bv_->cursor()/cursor_/ on BufferView_pimpl.C. Indeed, BufferView::cursor() is defined as: LCursor & BufferView::cursor() { return pimpl_->cursor_; } LCursor const & BufferView::cursor() const { return pimpl_->cursor_; } Therefore