Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | The following patch is the result of a simple s/bv_->cursor()/cursor_/ | on BufferView_pimpl.C. Indeed, BufferView::cursor() is defined as: > | LCursor & BufferView::cursor() | { | return pimpl_->cursor_; | } > > | LCursor const & BufferView::cursor() const | { | return pimpl_->cursor_; | } > > | Therefore, the patch does not change anything functionally, but avoids | a silly roundtrip (and makes code clearer IMO). > | If this kind of cleanup is welcome, the following on the list are | bv_->buffer(), bv_->owner() and bv_->isSavedPosition(i). > | Comments?
I like it. We should reduce these up-calls as much as possible. Would be brilliant if we came to the point where the pimpl owner did not have to be present at all. -- Lgb