Re: [PATCH] Re-worked patch for #228457

2001-06-04 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | On Tue, Jun 05, 2001 at 12:23:08AM +0200, Lars Gullik Bj?nnes wrote: | | > | string const String(Buffer const *, bool label); | > | - /// | > | - string const String(Buffer const *, size_type beg, size_type end); | > | + /// if withlabels is false, don'

Re: [PATCH] Re-worked patch for #228457

2001-06-04 Thread John Levon
On Tue, Jun 05, 2001 at 12:23:08AM +0200, Lars Gullik Bj?nnes wrote: > | string const String(Buffer const *, bool label); > | - /// > | - string const String(Buffer const *, size_type beg, size_type end); > | + /// if withlabels is false, don't include label strings > | + string const

Re: [PATCH] Re-worked patch for #228457

2001-06-04 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | bool CutAndPaste::checkPastePossible(LyXParagraph *) | { | -if (!buf) return false; | - | -return true; | + return buf; | } I don't like this. at most change it to return buf ? true : false; but this is probably just me... | di

[PATCH] Re-worked patch for #228457

2001-06-01 Thread John Levon
attached is the previous patch for pasting externally with better naming as pointed out by jmarc thanks john p.s. are we still planning to move to binutils-style patch applying system ? it would be lot less load if I could apply this myself after waiting for one or two "approved" responses --