Re: [PATCH] Optimize drawing

2006-11-16 Thread Abdelrazak Younes
Martin Vermeer wrote: Quoting Abdelrazak Younes <[EMAIL PROTECTED]>: Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> IMO, optimizing LyX is a must for 1.5.0. Current drawing Abdelrazak> strategy is really, *really*, complicated. So cleanu

Re: [PATCH] Optimize drawing

2006-11-16 Thread Martin Vermeer
Quoting Abdelrazak Younes <[EMAIL PROTECTED]>: Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> IMO, optimizing LyX is a must for 1.5.0. Current drawing Abdelrazak> strategy is really, *really*, complicated. So cleanups are Abdelrazak> nece

Re: [PATCH] Optimize drawing

2006-11-15 Thread Bennett Helm
On Nov 15, 2006, at 1:52 PM, Peter Kümmel wrote: Bennett Helm wrote: False alarm. Something was messed up on my computer causing this problem; a restart fixed it. This is fine now. Speed in insets seems fine with the patch. (There are still some drawing issues with nested insets that exist

Re: [PATCH] Optimize drawing

2006-11-15 Thread Peter Kümmel
Bennett Helm wrote: > On Nov 15, 2006, at 10:29 AM, Bennett Helm wrote: > >> On Nov 14, 2006, at 12:18 PM, Abdelrazak Younes wrote: >> >>> Hello, >>> >>> Between two chunk of work, I've managed to finish the patch, so here >>> it is. >>> >>> With this patch, when you click anywhere, including with

Re: [PATCH] Optimize drawing

2006-11-15 Thread Bennett Helm
On Nov 15, 2006, at 10:29 AM, Bennett Helm wrote: On Nov 14, 2006, at 12:18 PM, Abdelrazak Younes wrote: Hello, Between two chunk of work, I've managed to finish the patch, so here it is. With this patch, when you click anywhere, including within nested text insets (not for mathed), the

Re: [PATCH] Optimize drawing

2006-11-15 Thread Bennett Helm
On Nov 14, 2006, at 12:18 PM, Abdelrazak Younes wrote: Hello, Between two chunk of work, I've managed to finish the patch, so here it is. With this patch, when you click anywhere, including within nested text insets (not for mathed), there is no redrawing at _all_. This is an improvemen

Re: [PATCH] Optimize drawing

2006-11-15 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> IMO, optimizing LyX is a must for 1.5.0. Current drawing Abdelrazak> strategy is really, *really*, complicated. So cleanups are Abdelrazak> necessary in order to optimize it. I agree that we s

Re: [PATCH] Optimize drawing

2006-11-15 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> IMO, optimizing LyX is a must for 1.5.0. Current drawing Abdelrazak> strategy is really, *really*, complicated. So cleanups are Abdelrazak> necessary in order to optimize it. I agree that we shall take the time to spe

Re: [PATCH] Optimize drawing

2006-11-15 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Well, it does impact what the Mac user would feel. Waiting Abdelrazak> a second or two on each mouse click is not funny I guess. A second or two? I missed that. I seem to remember that from

Re: [PATCH] Optimize drawing

2006-11-15 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Well, it does impact what the Mac user would feel. Waiting Abdelrazak> a second or two on each mouse click is not funny I guess. A second or two? I missed that. >> Abdel, besides the "do it right" aspect of the patch

Re: [PATCH] Optimize drawing

2006-11-15 Thread Abdelrazak Younes
José Matos wrote: On Tuesday 14 November 2006 5:18 pm, Abdelrazak Younes wrote: With this patch, when you click anywhere, including within nested text insets (not for mathed), there is no redrawing at _all_. This is an improvement over lyx-1.4 where the full screen were redrawn two times on each

Re: [PATCH] Optimize drawing

2006-11-15 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "José" == José Matos <[EMAIL PROTECTED]> writes: With this patch, when you click anywhere, including within nested text insets (not for mathed), there is no redrawing at _all_. This is an improvement over lyx-1.4 where the full screen were redrawn two times on each

Re: [PATCH] Optimize drawing

2006-11-15 Thread Jean-Marc Lasgouttes
> "José" == José Matos <[EMAIL PROTECTED]> writes: >> With this patch, when you click anywhere, including within nested >> text insets (not for mathed), there is no redrawing at _all_. This >> is an improvement over lyx-1.4 where the full screen were redrawn >> two times on each mouse click. >

Re: [PATCH] Optimize drawing

2006-11-15 Thread José Matos
On Tuesday 14 November 2006 5:18 pm, Abdelrazak Younes wrote: > Hello, > > Between two chunk of work, I've managed to finish the patch, so here it is. Good. > With this patch, when you click anywhere, including within nested text > insets (not for mathed), there is no redrawing at _all_. This i

Re: [PATCH] Optimize drawing (was Re: CT Status Quo)

2006-11-15 Thread José Matos
On Sunday 12 November 2006 11:38 pm, Abdelrazak Younes wrote: > I might not be ready for this alpha but I will for the next. Thanks Abdel. I would like to have feedback from Bennet before putting this in. I think that we are in the right track. :-) > Abdel. -- José Abílio

Re: [PATCH] Optimize drawing

2006-11-14 Thread Abdelrazak Younes
John Levon wrote: On Tue, Nov 14, 2006 at 06:18:08PM +0100, Abdelrazak Younes wrote: // When the above and the inner function are fixed, we can do this: - //return needRedraw; + return needRedraw; return true; Need to remove the second return Indeed, thanks. Abd

Re: [PATCH] Optimize drawing

2006-11-14 Thread Peter Kümmel
Abdelrazak Younes wrote: > Hello, > > Between two chunk of work, I've managed to finish the patch, so here it is. > > With this patch, when you click anywhere, including within nested text > insets (not for mathed), there is no redrawing at _all_. This is an > improvement over lyx-1.4 where the f

Re: [PATCH] Optimize drawing

2006-11-14 Thread John Levon
On Tue, Nov 14, 2006 at 06:18:08PM +0100, Abdelrazak Younes wrote: > // When the above and the inner function are fixed, we can do this: > - //return needRedraw; > + return needRedraw; > return true; Need to remove the second return john

[PATCH] Optimize drawing

2006-11-14 Thread Abdelrazak Younes
Hello, Between two chunk of work, I've managed to finish the patch, so here it is. With this patch, when you click anywhere, including within nested text insets (not for mathed), there is no redrawing at _all_. This is an improvement over lyx-1.4 where the full screen were redrawn two times on

[PATCH] Optimize drawing (was Re: CT Status Quo)

2006-11-12 Thread Abdelrazak Younes
Michael Gerz wrote: Dear Jose, Nov 13th is getting closer (oops, it's already there) and, to my greatest regret, I haven't managed to fix all CT problems. And I haven't manage to fix some performance problem... But I am very close :-) Attached patch minimizes considerably the number of met