Re: [PATCH] Layout Modularity, Part I

2007-08-26 Thread Andre Poenitz
On Fri, Aug 24, 2007 at 09:43:18AM -0400, Richard Heck wrote: > Andre Poenitz wrote: > >>If people really want me to change all of these, I'll do so. But this > >>was modeled on the existing Layout_ptr. > >> > >I guess I'll just rename Layout_ptr into LayoutPtr to avoid this in the > >furture.

Re: [PATCH] Layout Modularity, Part I

2007-08-24 Thread Richard Heck
Abdelrazak Younes wrote: Abdelrazak Younes wrote: Richard Heck wrote: (iii) remember layout base class _and_ module in BufferParams. Maybe the solution is to have a global TextClassModule along the global TextClassList instead of having local copies of TextClass? Or integrate the module acces

Re: [PATCH] Layout Modularity, Part I

2007-08-24 Thread Richard Heck
Andre Poenitz wrote: If people really want me to change all of these, I'll do so. But this was modeled on the existing Layout_ptr. I guess I'll just rename Layout_ptr into LayoutPtr to avoid this in the furture. I'll change TextClass_ptr to TextClassPtr later. I don't want to do it now

Re: [PATCH] Layout Modularity, Part I

2007-08-23 Thread Andre Poenitz
On Thu, Aug 23, 2007 at 10:50:41AM -0500, Bo Peng wrote: > > Sure...though I can't promise competence with minizip, etc. > > No. You do not have to worry about minizip. No one understands that > part of the code. Use zipFiles and unzipToDir as two black boxes. > > > There's no feature yet. I'm tr

Re: [PATCH] Layout Modularity, Part I

2007-08-23 Thread Andre Poenitz
On Thu, Aug 23, 2007 at 11:40:08AM -0400, Richard Heck wrote: > Bo Peng wrote: > >In my institution, because few people are willing to review others' > >grant, there is a submit one, review one policy. If we adopt this rule > >here, you should go ahead and review my Embedding patch. :-) > > > Sur

Re: [PATCH] Layout Modularity, Part I

2007-08-23 Thread Alfredo Braunstein
Andre Poenitz wrote: > I too. > > Andre' You tooed too much already! A/

Re: [PATCH] Layout Modularity, Part I

2007-08-23 Thread Andre Poenitz
On Wed, Aug 22, 2007 at 11:03:24PM -0500, Bo Peng wrote: > In my institution, because few people are willing to review others' > grant, there is a submit one, review one policy. If we adopt this rule > here, you should go ahead and review my Embedding patch. :-) > > First, could you disclose a lit

Re: [PATCH] Layout Modularity, Part I

2007-08-23 Thread Richard Heck
Abdelrazak Younes wrote: Previously, it just held an index into TextClassList, and extending that would lead to solution (i). I suppose you could have some kind of next TextClass-thingy that kept a list of modules that are in use. But that presumes that the contents of the modules don't change

Re: [PATCH] Layout Modularity, Part I

2007-08-23 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Richard Heck wrote: (iii) remember layout base class _and_ module in BufferParams. Maybe the solution is to have a global TextClassModule along the global TextClassList instead of having local copies of TextClass? Or integrate the module access to the TextClassList its

Re: [PATCH] Layout Modularity, Part I

2007-08-23 Thread Abdelrazak Younes
Richard Heck wrote: Abdelrazak Younes wrote: Richard Heck wrote: The pointer in question is a boost::shared_ptr. This is needed because CutAndPaste saves a copy of the layout with each cut or copied selection. We cannot assume the selection vanishes when the document is closed, so there are t

Re: [PATCH] Layout Modularity, Part I

2007-08-23 Thread Richard Heck
Bo Peng wrote: There's no feature yet. I'm trying to follow the "divide your patch into logical bits" rule. This one just reworks the infrastructure to prepare for modules, which will come next. I was asking for a big picture. Oh, yes, then: There'll be a UI, and two LFUNs: clear-modules

Re: [PATCH] Layout Modularity, Part I

2007-08-23 Thread Richard Heck
Abdelrazak Younes wrote: Richard Heck wrote: The pointer in question is a boost::shared_ptr. This is needed because CutAndPaste saves a copy of the layout with each cut or copied selection. We cannot assume the selection vanishes when the document is closed, so there are two options: (i) keep

Re: [PATCH] Layout Modularity, Part I

2007-08-23 Thread Bo Peng
> Sure...though I can't promise competence with minizip, etc. No. You do not have to worry about minizip. No one understands that part of the code. Use zipFiles and unzipToDir as two black boxes. > There's no feature yet. I'm trying to follow the "divide your patch into > logical bits" rule. This

Re: [PATCH] Layout Modularity, Part I

2007-08-23 Thread Richard Heck
Bo Peng wrote: In my institution, because few people are willing to review others' grant, there is a submit one, review one policy. If we adopt this rule here, you should go ahead and review my Embedding patch. :-) Sure...though I can't promise competence with minizip, etc. First, could you

Re: [PATCH] Layout Modularity, Part I

2007-08-23 Thread Abdelrazak Younes
Richard Heck wrote: The pointer in question is a boost::shared_ptr. This is needed because CutAndPaste saves a copy of the layout with each cut or copied selection. We cannot assume the selection vanishes when the document is closed, so there are two options: (i) keep a list of all the layouts

Re: [PATCH] Layout Modularity, Part I

2007-08-22 Thread Abdelrazak Younes
Richard Heck wrote: Andre Poenitz wrote: On Wed, Aug 22, 2007 at 07:44:17PM -0400, Richard Heck wrote: Andre Poenitz wrote: Looks good in general. Good. I find the naming TextClass_sptr exceptionally ugle (CamelBump and under_score mixed), but I know there are unfortunate precenden

Re: [PATCH] Layout Modularity, Part I

2007-08-22 Thread Martin Vermeer
On Wed, Aug 22, 2007 at 07:03:50PM -0400, Richard Heck wrote: > This is one of a series of patches that will merge the layout modules > development in personal/branches/rgheck back into the tree. ... > Index: src/BufferParams.h > =

Re: [PATCH] Layout Modularity, Part I

2007-08-22 Thread Bo Peng
In my institution, because few people are willing to review others' grant, there is a submit one, review one policy. If we adopt this rule here, you should go ahead and review my Embedding patch. :-) First, could you disclose a little bit how to use this feature? Is there a GUI to add modules?

Re: [PATCH] Layout Modularity, Part I

2007-08-22 Thread Richard Heck
Andre Poenitz wrote: On Wed, Aug 22, 2007 at 07:44:17PM -0400, Richard Heck wrote: Andre Poenitz wrote: Looks good in general. Good. I find the naming TextClass_sptr exceptionally ugle (CamelBump and under_score mixed), but I know there are unfortunate precendents (Layout_ptr). I

Re: [PATCH] Layout Modularity, Part I

2007-08-22 Thread Andre Poenitz
On Wed, Aug 22, 2007 at 07:44:17PM -0400, Richard Heck wrote: > Andre Poenitz wrote: > >The file TextClass_sptr.h seems to be missing from the patch? > > > Yes, sorry. Here it is. Looks good in general. I find the naming TextClass_sptr exceptionally ugle (CamelBump and under_score mixed), but I

Re: [PATCH] Layout Modularity, Part I

2007-08-22 Thread Richard Heck
Andre Poenitz wrote: The file TextClass_sptr.h seems to be missing from the patch? Yes, sorry. Here it is. rh -- == Richard G Heck, Jr Professor of Philosophy Brown University http://frege.brown.edu/heck/ ==

Re: [PATCH] Layout Modularity, Part I

2007-08-22 Thread Andre Poenitz
On Wed, Aug 22, 2007 at 07:03:50PM -0400, Richard Heck wrote: > This is one of a series of patches that will merge the layout modules > development in personal/branches/rgheck back into the tree. > > Design goal: Allow the use of layout "modules", which are to LaTeX > packages as layout files ar

[PATCH] Layout Modularity, Part I

2007-08-22 Thread Richard Heck
This is one of a series of patches that will merge the layout modules development in personal/branches/rgheck back into the tree. Design goal: Allow the use of layout "modules", which are to LaTeX packages as layout files are to LaTeX document classes. Thus, one could have a module that define