Richard Heck wrote:
Andre Poenitz wrote:
On Wed, Aug 22, 2007 at 07:44:17PM -0400, Richard Heck wrote:
Andre Poenitz wrote:
Looks good in general.
Good.
I find the naming TextClass_sptr exceptionally ugle (CamelBump and
under_score mixed), but I know there are unfortunate precendents
(Layout_ptr). I guess I'd prefer TextClassPtr nevertheless.
I took it from the existing precedents. The ugly naming does at least
signal there's something unusual about the file.
Still, I personally don't like this using of shared_ptr. Isn't it
possible that, instead of owning the changed TextClass, BufferParams
would create this TextClass and register it in the TextClassList under a
new identifier (which BufferParam will store)? This way the TextClass
will remain accessible after the Buffer is closed...
Just an idea.
Abdel.
