Re: [PATCH] inset caption cleanup

2007-02-04 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> OK, we'll see. Since it is in now there is little ponit arguing >> anyway. Abdelrazak> Do you honnestly think that the old caption layout was Abdelrazak> better? The old system was customizable. Where do I specify the font u

Re: [PATCH] inset caption cleanup

2007-02-02 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >>> The following patch cleans up the insetcaption code wrt allowing >>> inset insertion: I committed the patch, and re-allowed the following LFUNs, for which I do not see a need to act: - case LFUN_PARAGRAPH_MOVE_UP: -

Re: [PATCH] inset caption cleanup

2007-02-02 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Jean-Marc Lasgouttes wrote: The following patch cleans up the insetcaption code wrt allowing inset insertion: - allow graphics inset, since it has been working for some time (but I forgot to

Re: [PATCH] inset caption cleanup

2007-02-02 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Jean-Marc Lasgouttes wrote: >> The following patch cleans up the insetcaption code wrt allowing >> inset insertion: >> >> - allow graphics inset, since it has been working for some time >> (but I forgot to tell) Abde

Re: [PATCH] inset caption cleanup

2007-02-02 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: The following patch cleans up the insetcaption code wrt allowing inset insertion: - allow graphics inset, since it has been working for some time (but I forgot to tell) What is this about? - use insetAllowed to disallow some insets (as should be) I just fol

[PATCH] inset caption cleanup

2007-02-02 Thread Jean-Marc Lasgouttes
The following patch cleans up the insetcaption code wrt allowing inset insertion: - allow graphics inset, since it has been working for some time (but I forgot to tell) - use insetAllowed to disallow some insets (as should be) The is still the input inset that has been forbidden, and I am no

Re: [PATCH] Inset Caption

2007-01-29 Thread younes . a
Quoting Martin Vermeer <[EMAIL PROTECTED]>: > On Fri, 2007-01-26 at 17:31 +0100, Abdelrazak Younes wrote: > > Georg Baum wrote: > > > Abdelrazak Younes wrote: > > > > > >> Hello, > > >> > > >> Here is a correctly working version of the Inset Caption feature. The > > >> only problem is the wide pro

Re: [PATCH] Inset Caption

2007-01-29 Thread Martin Vermeer
On Fri, 2007-01-26 at 17:31 +0100, Abdelrazak Younes wrote: > Georg Baum wrote: > > Abdelrazak Younes wrote: > > > >> Hello, > >> > >> Here is a correctly working version of the Inset Caption feature. The > >> only problem is the wide property when writing in it. > > > > Is that difficult to solv

Re: [FINAL PATCH] Inset Caption

2007-01-27 Thread Enrico Forestieri
On Sat, Jan 27, 2007 at 04:08:10PM +0100, Georg Baum wrote: > - AFAIK not all layouts have a caption style, but with this patch we allow > captions in any documents. Is this a problem? I think that even the more stupid things should be allowed as far as they don't produce errors, ie. latex accep

Re: [FINAL PATCH] Inset Caption

2007-01-27 Thread Abdelrazak Younes
Georg Baum wrote: Am Samstag, 27. Januar 2007 13:10 schrieb Abdelrazak Younes: Georg, if you're going to do the lyx2lyx support, please take the patch and commit it at the same time. Here is the complete patch, but I discovered some problems that need to be solved before it can go in: - Y

Re: [FINAL PATCH] Inset Caption

2007-01-27 Thread Georg Baum
Am Samstag, 27. Januar 2007 13:10 schrieb Abdelrazak Younes: > Jürgen Spitzmüller wrote: > > Am Freitag, 26. Januar 2007 22:57 schrieb Abdelrazak Younes: > >> 1) LateX doesn't accept multiple lines caption so we might have to > >> forbid that I guess. > > > > I think a line break is allowed, but n

Re: [FINAL PATCH] Inset Caption

2007-01-27 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > What is a line break? If it is mean the one with Ctrl-Enter, Yes. > LateX does > not like it. If you mean normal row-breaking (word-wrap), that is OK > with LateX. Works for me (article.cls). What error do you get? > >> 2) If you put multiple captions inside a same

[FINAL PATCH] Inset Caption

2007-01-27 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Am Freitag, 26. Januar 2007 22:57 schrieb Abdelrazak Younes: 1) LateX doesn't accept multiple lines caption so we might have to forbid that I guess. I think a line break is allowed, but no paragraph break. What is a line break? If it is mean the one with Ctrl-Enter,

Re: [Updated PATCH] Inset Caption

2007-01-27 Thread Jürgen Spitzmüller
Am Freitag, 26. Januar 2007 22:57 schrieb Abdelrazak Younes: > 1) LateX doesn't accept multiple lines caption so we might have to > forbid that I guess. I think a line break is allowed, but no paragraph break. > 2) If you put multiple captions inside a same float, they are numbered > sequentially

Re: [Updated PATCH] Inset Caption

2007-01-26 Thread Abdelrazak Younes
Georg Baum wrote: Am Freitag, 26. Januar 2007 22:36 schrieb Abdelrazak Younes: Here is an updated patch with cleaner code and that works better when the caption is embedded in another inset (Note, Branch, etc). So shall I commit? Not without the lyx2lyx stuff please. Of course. Are you

Re: [Updated PATCH] Inset Caption

2007-01-26 Thread Georg Baum
Am Freitag, 26. Januar 2007 22:36 schrieb Abdelrazak Younes: > Here is an updated patch with cleaner code and that works better when > the caption is embedded in another inset (Note, Branch, etc). > > So shall I commit? Not without the lyx2lyx stuff please. > Are you ready to put the lyx2lyx co

[Updated PATCH] Inset Caption

2007-01-26 Thread Abdelrazak Younes
Georg Baum wrote: Abdelrazak Younes wrote: Hello, Here is a correctly working version of the Inset Caption feature. The only problem is the wide property when writing in it. Is that difficult to solve? You have to uncomment the "#define INSET_CAPTION" line in insetcaption.h in order to try

Re: [PATCH] Inset Caption

2007-01-26 Thread Abdelrazak Younes
Georg Baum wrote: Abdelrazak Younes wrote: Hello, Here is a correctly working version of the Inset Caption feature. The only problem is the wide property when writing in it. Is that difficult to solve? Probably yes. Needs some debugging work... Martin, as you are the expert of this "wide"

Re: [PATCH] Inset Caption

2007-01-26 Thread Georg Baum
Abdelrazak Younes wrote: > Hello, > > Here is a correctly working version of the Inset Caption feature. The > only problem is the wide property when writing in it. Is that difficult to solve? > You have to uncomment the "#define INSET_CAPTION" line in insetcaption.h > in order to try it (it is

[PATCH] Inset Caption

2007-01-26 Thread Abdelrazak Younes
Hello, Here is a correctly working version of the Inset Caption feature. The only problem is the wide property when writing in it. You have to uncomment the "#define INSET_CAPTION" line in insetcaption.h in order to try it (it is disabled by default). I propose to put this in and to enable it