Re: [PATCH] Fix tabular crashes

2006-10-20 Thread Georg Baum
Juergen Spitzmueller wrote: > how about a horizontal scrollbar in such cases? Yes: http://bugzilla.lyx.org/show_bug.cgi?id=1083 Georg

Re: [PATCH] Fix tabular crashes

2006-10-20 Thread Juergen Spitzmueller
Georg Baum wrote: > I had a look at the code, and I believe that it is for horizontal > "scrolling": If you have a table that is wider than the screen and you go > to a cell that is at the right edge then, if you are lucky, the table is > shifted to the left so that you can edit the cell and even g

Re: [PATCH] Fix tabular crashes

2006-10-20 Thread Martin Vermeer
On Fri, Oct 20, 2006 at 05:08:24PM +0200, Abdelrazak Younes wrote: > Abdelrazak Younes wrote: > >OK, I've found the bloody source of the tabular crash. I don't know what > >this resetPos() method is for but it should be used carefully. > > Here's an alternate patch. Which one do you prefer? > >

Re: [PATCH] Fix tabular crashes

2006-10-20 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Georg Baum wrote: Abdelrazak Younes wrote: Nobody knows what this resetPos() is for? I had a look at the code, and I believe that it is for horizontal "scrolling": If you have a table that is wider than the screen and you go to a cell that is at the right edge then,

Re: [PATCH] Fix tabular crashes

2006-10-20 Thread Abdelrazak Younes
Georg Baum wrote: Abdelrazak Younes wrote: Nobody knows what this resetPos() is for? I had a look at the code, and I believe that it is for horizontal "scrolling": If you have a table that is wider than the screen and you go to a cell that is at the right edge then, if you are lucky, the tabl

Re: [PATCH] Fix tabular crashes

2006-10-20 Thread Georg Baum
Abdelrazak Younes wrote: > Nobody knows what this resetPos() is for? I had a look at the code, and I believe that it is for horizontal "scrolling": If you have a table that is wider than the screen and you go to a cell that is at the right edge then, if you are lucky, the table is shifted to the

Re: [PATCH] Fix tabular crashes

2006-10-20 Thread Abdelrazak Younes
Georg Baum wrote: Abdelrazak Younes wrote: Abdelrazak Younes wrote: OK, I've found the bloody source of the tabular crash. I don't know what this resetPos() method is for but it should be used carefully. Here's an alternate patch. Which one do you prefer? The other one. It makes clear that

Re: [PATCH] Fix tabular crashes

2006-10-20 Thread Abdelrazak Younes
Georg Baum wrote: Abdelrazak Younes wrote: Abdelrazak Younes wrote: OK, I've found the bloody source of the tabular crash. I don't know what this resetPos() method is for but it should be used carefully. Here's an alternate patch. Which one do you prefer? The other one. It makes clear that

Re: [PATCH] Fix tabular crashes

2006-10-20 Thread Georg Baum
Abdelrazak Younes wrote: > Abdelrazak Younes wrote: >> OK, I've found the bloody source of the tabular crash. I don't know what >> this resetPos() method is for but it should be used carefully. > > Here's an alternate patch. Which one do you prefer? The other one. It makes clear that there is a

Re: [PATCH] Fix tabular crashes

2006-10-20 Thread Abdelrazak Younes
Abdelrazak Younes wrote: OK, I've found the bloody source of the tabular crash. I don't know what this resetPos() method is for but it should be used carefully. Here's an alternate patch. Which one do you prefer? Martin, can I call this one a "fix"? :-) Abdel. Index: coordcache.h

Re: [PATCH] Fix tabular crashes

2006-10-20 Thread Abdelrazak Younes
Martin Vermeer wrote: On Fri, 2006-10-20 at 16:30 +0200, Abdelrazak Younes wrote: OK, I've found the bloody source of the tabular crash. I don't know what this resetPos() method is for but it should be used carefully. Will commit soon if there's no objection. Abdel. Don't you feel that you

Re: [PATCH] Fix tabular crashes

2006-10-20 Thread Martin Vermeer
On Fri, 2006-10-20 at 16:30 +0200, Abdelrazak Younes wrote: > OK, I've found the bloody source of the tabular crash. I don't know what > this resetPos() method is for but it should be used carefully. > > Will commit soon if there's no objection. > > Abdel. Don't you feel that you *ought* to und

[PATCH] Fix tabular crashes

2006-10-20 Thread Abdelrazak Younes
OK, I've found the bloody source of the tabular crash. I don't know what this resetPos() method is for but it should be used carefully. Will commit soon if there's no objection. Abdel. Index: insettabular.C === --- insettabular.C