Re: [PATCH] Fix regression with end-of-par markers

2016-03-29 Thread Jean-Marc Lasgouttes
Le 27/03/2016 21:19, Kornel Benko a écrit : I suspect a compiler bug. What is your compiler? Can you try another one? I am compiling with g++ (GCC) 5.3.0 but tried also gcc version 4.8.4 (Ubuntu 4.8.4-2ubuntu1~14.04.1). No change in behaviour. The linking order might be different between au

Re: [PATCH] Fix regression with end-of-par markers

2016-03-27 Thread Kornel Benko
Am Sonntag, 27. März 2016 um 19:37:33, schrieb Jean-Marc Lasgouttes > Le 26/03/2016 20:58, Kornel Benko a écrit : > > Much more of output, but this time not always the same. > > > > insetfont: Roman, Medium, Upright, Tiny, none, Emphasis Off, Underline Off, > > Strikeout Off, Double underline Of

Static member initialization ordering bug (was: [PATCH] Fix regression with end-of-par markers)

2016-03-27 Thread Jean-Marc Lasgouttes
Le 27/03/2016 19:37, Jean-Marc Lasgouttes a écrit : I suspect a compiler bug. What is your compiler? Can you try another one? I think I know what happens: in TextClass.cpp, we have InsetLayout DocumentClass::plain_insetlayout_; The InsetLayout constructor says: InsetLayout::InsetLayout() : [..

Re: [PATCH] Fix regression with end-of-par markers

2016-03-27 Thread Jean-Marc Lasgouttes
Le 27/03/2016 19:37, Jean-Marc Lasgouttes a écrit : Try this patch instead, which shows the font size of the default insetlayout. Here I have (lots of) plain insetlayout fontsize: 12 This is INHERIT_SIZE. The font of the default inset layout should be all_inherit. I suspect a compiler bug. What

Re: [PATCH] Fix regression with end-of-par markers

2016-03-27 Thread Jean-Marc Lasgouttes
Le 26/03/2016 20:58, Kornel Benko a écrit : Much more of output, but this time not always the same. insetfont: Roman, Medium, Upright, Tiny, none, Emphasis Off, Underline Off, Strikeout Off, Double underline Off, Wavy underline Off, Noun Off, The problem is this one. The inset font of the mai

Re: [PATCH] Fix regression with end-of-par markers

2016-03-26 Thread Kornel Benko
Am Samstag, 26. März 2016 um 20:31:24, schrieb Jean-Marc Lasgouttes > Le 26/03/2016 19:47, Kornel Benko a écrit : > >> Well, except that font size is "Tiny" instead of "Larger"! Where does > >> this come from? Do you have local layout files somewhere? > > > > No local layouts. > > > >> It is also

Re: [PATCH] Fix regression with end-of-par markers

2016-03-26 Thread Jean-Marc Lasgouttes
Le 26/03/2016 19:47, Kornel Benko a écrit : Well, except that font size is "Tiny" instead of "Larger"! Where does this come from? Do you have local layout files somewhere? No local layouts. It is also Medium instead of Bold. Is this a section heading? Yes. And the output does not depend of

Re: [PATCH] Fix regression with end-of-par markers

2016-03-26 Thread Kornel Benko
Am Samstag, 26. März 2016 um 19:41:00, schrieb Jean-Marc Lasgouttes > Le 26/03/2016 19:19, Kornel Benko a écrit : > > Am Samstag, 26. März 2016 um 18:30:22, schrieb Jean-Marc Lasgouttes > > > >> Le 25/03/2016 22:24, Jean-Marc Lasgouttes a écrit : > >>> Concerning the font problem, I'll try to c

Re: [PATCH] Fix regression with end-of-par markers

2016-03-26 Thread Jean-Marc Lasgouttes
Le 26/03/2016 19:19, Kornel Benko a écrit : Am Samstag, 26. März 2016 um 18:30:22, schrieb Jean-Marc Lasgouttes Le 25/03/2016 22:24, Jean-Marc Lasgouttes a écrit : Concerning the font problem, I'll try to come up with a debugging patch. Kornel, could you try this patch? With it, when I inse

Re: [PATCH] Fix regression with end-of-par markers

2016-03-26 Thread Kornel Benko
Am Samstag, 26. März 2016 um 18:30:22, schrieb Jean-Marc Lasgouttes > Le 25/03/2016 22:24, Jean-Marc Lasgouttes a écrit : > > Concerning the font problem, I'll try to come up with a debugging patch. > > Kornel, could you try this patch? With it, when I insert a section > heading in a new docume

Re: [PATCH] Fix regression with end-of-par markers

2016-03-26 Thread Jean-Marc Lasgouttes
Le 25/03/2016 22:24, Jean-Marc Lasgouttes a écrit : Concerning the font problem, I'll try to come up with a debugging patch. Kornel, could you try this patch? With it, when I insert a section heading in a new document and press return, I see Marker font: Roman, Bold, Upright, Larger, none, E

Re: [PATCH] Fix regression with end-of-par markers

2016-03-25 Thread Kornel Benko
Am Freitag, 25. März 2016 um 22:24:41, schrieb Jean-Marc Lasgouttes > Le 25/03/2016 20:39, Stephan Witt a écrit : > >> Le 25/03/2016 11:46, Kornel Benko a écrit : > >>> +1. But the marker are practically invisible. This is not the fault > >>> of this patch, they > >>> are invisible also without.

Re: [PATCH] Fix regression with end-of-par markers

2016-03-25 Thread Jean-Marc Lasgouttes
Le 25/03/2016 20:39, Stephan Witt a écrit : Le 25/03/2016 11:46, Kornel Benko a écrit : +1. But the marker are practically invisible. This is not the fault of this patch, they are invisible also without. +1 for the patch. Thanks to both of you for testing. I put it in. Concerning the font p

Re: [PATCH] Fix regression with end-of-par markers

2016-03-25 Thread Kornel Benko
Am Freitag, 25. März 2016 um 21:39:06, schrieb Jean-Marc Lasgouttes > Le 25/03/16 19:11, Kornel Benko a écrit : > >> Your marker are about the same hight as your font, in my case it looks > >> like only half as high. > >> > >> OTOH, using lyx2.1 the marker-sizes are OK. > >> So this is a mystery

Re: [PATCH] Fix regression with end-of-par markers

2016-03-25 Thread Jean-Marc Lasgouttes
Le 25/03/16 19:11, Kornel Benko a écrit : Your marker are about the same hight as your font, in my case it looks like only half as high. OTOH, using lyx2.1 the marker-sizes are OK. So this is a mystery for me. Is it a matter of zoom or dpi? Tried to compile earlier version ... f215bb3 Lyx s

Re: [PATCH] Fix regression with end-of-par markers

2016-03-25 Thread Kornel Benko
Am Freitag, 25. März 2016 um 12:20:52, schrieb Kornel Benko > Am Freitag, 25. März 2016 um 12:02:20, schrieb Jean-Marc Lasgouttes > > > Le 25/03/2016 11:46, Kornel Benko a écrit : > > > Am Freitag, 25. März 2016 um 11:07:35, schrieb Jean-Marc Lasgouttes > > > > > >> Dear all, > > >> > > >> Her

Re: [PATCH] Fix regression with end-of-par markers

2016-03-25 Thread Kornel Benko
Am Freitag, 25. März 2016 um 12:02:20, schrieb Jean-Marc Lasgouttes > Le 25/03/2016 11:46, Kornel Benko a écrit : > > Am Freitag, 25. März 2016 um 11:07:35, schrieb Jean-Marc Lasgouttes > > > >> Dear all, > >> > >> Here is a candidate patch for LyX 2.2.0, which fixes a couple of > >> regression

Re: [PATCH] Fix regression with end-of-par markers

2016-03-25 Thread Jean-Marc Lasgouttes
Le 25/03/2016 12:02, Jean-Marc Lasgouttes a écrit : That is pretty strange, the markers are supposed to be bigger in 2.2 than in 2.1, since they inherit the font of the paragraph now (see attached screenshot). Was the situation better in 2.1? Does it depend on your screen font? What is your platf

Re: [PATCH] Fix regression with end-of-par markers

2016-03-25 Thread Kornel Benko
Am Freitag, 25. März 2016 um 11:07:35, schrieb Jean-Marc Lasgouttes > Dear all, > > Here is a candidate patch for LyX 2.2.0, which fixes a couple of > regressions wrt 2.1.x with end-of-par markers. The example file > demonstrates the two regressions: > * end marker should appear after empty rows

[PATCH] Fix regression with end-of-par markers

2016-03-25 Thread Jean-Marc Lasgouttes
Dear all, Here is a candidate patch for LyX 2.2.0, which fixes a couple of regressions wrt 2.1.x with end-of-par markers. The example file demonstrates the two regressions: * end marker should appear after empty rows ending paragraph * end marker should never appear after a newline Looking fo