Re: [PATCH] EmbeddedFile and InsetBibtex

2008-03-29 Thread rgheck
Bo Peng wrote: InsetBibtex::setParams(p) { InsetCommand::setParams(p); updateBibFiles(); } It is not as easy as this (sound familiar? :-). p may have to be changed depending on the result of updateBibFiles because it may come out that a file cannot be embedded at all, and then p

Re: [PATCH] EmbeddedFile and InsetBibtex

2008-03-29 Thread Bo Peng
> InsetBibtex::setParams(p) > { > InsetCommand::setParams(p); > updateBibFiles(); > } It is not as easy as this (sound familiar? :-). p may have to be changed depending on the result of updateBibFiles because it may come out that a file cannot be embedded at all, and then p['embed'] has

Re: [PATCH] EmbeddedFile and InsetBibtex

2008-03-29 Thread rgheck
Check the attached. It's more or less an inverse of what you had before. In place of updateParams(), we have updateBibFiles(). There are still some rough edges, though. But this will work, I think, without undermining the InsetCommand structures. Your patch is huge and many of them se