Bo Peng wrote:
 InsetBibtex::setParams(p)
 {
    InsetCommand::setParams(p);
    updateBibFiles();
 }

It is not as easy as this (sound familiar? :-). p may have to be
changed depending on the result of updateBibFiles because it may come
out that a file cannot be embedded at all, and then p['embed'] has to
be changed. Because of this, my current strategy is to update embedded
file list *first*, and then update params.

No, p isn't changed. The parameters are changed.
Please refrain from committing before we reach an agreement on such
basic issues.

I had meant to be committing only the uncontroversial bits.

rh

Reply via email to